fix: additionalProperties validation in baseWidgetLayoutsTemplateConfig#2289
Merged
tahmidefaz merged 1 commit intomasterfrom Mar 18, 2026
Merged
fix: additionalProperties validation in baseWidgetLayoutsTemplateConfig#2289tahmidefaz merged 1 commit intomasterfrom
tahmidefaz merged 1 commit intomasterfrom
Conversation
…onalProperties validation The breakpoint items (sm, md, lg, xl) had and additionalProperties: false as sibling keywords. In JSON Schema 2020-12, additionalProperties only considers properties defined in the same schema object, not those from . This caused ajv to reject all properties (w, h, cx, cy, i) as additional. Move inside allOf so templateConfigItem's own additionalProperties: false handles property restriction, while per-breakpoint constraints remain in a second allOf entry.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe PR refactors the JSON schema for per-breakpoint widget template configurations, converting from inline object definitions to allOf compositions. The same validation requirements are maintained; only the schema representation structure changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
restructure baseWidgetLayoutsTemplateConfig schema to fix additionalProperties validation
The breakpoint items (sm, md, lg, xl) had and additionalProperties: false
as sibling keywords. In JSON Schema 2020-12, additionalProperties only considers
properties defined in the same schema object, not those from . This caused
ajv to reject all properties (w, h, cx, cy, i) as additional.
Move inside allOf so templateConfigItem's own additionalProperties: false
handles property restriction, while per-breakpoint constraints remain in a
second allOf entry.