Skip to content
This repository was archived by the owner on Dec 18, 2025. It is now read-only.

Revert "feat(RHINENG-22427): Remove routing from policies completely …#606

Merged
adonispuente merged 1 commit intoRedHatInsights:masterfrom
adonispuente:revert
Dec 12, 2025
Merged

Revert "feat(RHINENG-22427): Remove routing from policies completely …#606
adonispuente merged 1 commit intoRedHatInsights:masterfrom
adonispuente:revert

Conversation

@adonispuente
Copy link
Collaborator

@adonispuente adonispuente commented Dec 12, 2025

…(#601)"

This reverts commit d745527.

Summary by Sourcery

Reintroduce frontend deployment configuration for the policies UI frontend and wire it into the project config.

Deployment:

  • Add an OpenShift Template-based Frontend CRD manifest for the policies UI frontend, including navigation, search, and module configuration.
  • Reference the new frontend CRD manifest from the frontend components configuration to enable deployment tooling integration.

@adonispuente adonispuente requested a review from a team as a code owner December 12, 2025 17:16
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 12, 2025

Reviewer's Guide

Reintroduces frontend CRD configuration for the policies UI by wiring a new OpenShift Template manifest into the fec config, restoring deployment metadata, navigation, and console integration for the Policies frontend.

File-Level Changes

Change Details Files
Wire the frontend CRD manifest into the frontend config utilities so the build/deploy pipeline uses the new OpenShift template.
  • Add frontendCRDPath property pointing to the frontend CRD manifest in the fec configuration object
  • Ensure configuration formatting remains valid after adding the new property
fec.config.js
Add an OpenShift Template-based Frontend CRD manifest defining how the Policies UI frontend is deployed and exposed in console.
  • Define Template and Frontend resources including envName, title, deploymentRepo, API versions, frontend paths, image, and FEO config flag
  • Configure service tile, search entry metadata, and bundle navigation segments for the Policies app
  • Define module configuration including manifest location, analytics key, support case metadata, and route mappings for /insights/policies and /ansible/policies
  • Introduce template parameters for environment name and image properties with defaults where appropriate
deploy/frontend.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@adonispuente adonispuente merged commit e97b848 into RedHatInsights:master Dec 12, 2025
2 of 7 checks passed
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

Blocking issues:

  • Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (link)

General comments:

  • In deploy/frontend.yml, the alt_title list contains conditions twice; consider deduplicating these entries to keep the search metadata clean and intentional.
  • The analytics APIKey is hard-coded in the CRD template; if possible, consider sourcing this from a parameter or secret rather than embedding it directly in the manifest.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `deploy/frontend.yml`, the `alt_title` list contains `conditions` twice; consider deduplicating these entries to keep the search metadata clean and intentional.
- The analytics `APIKey` is hard-coded in the CRD template; if possible, consider sourcing this from a parameter or secret rather than embedding it directly in the manifest.

## Individual Comments

### Comment 1
<location> `deploy/frontend.yml:66` </location>
<code_context>
apRCg9V6oMXCcnTingqRYW6m1er4hkCW
</code_context>

<issue_to_address>
**security (generic-api-key):** Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

*Source: gitleaks*
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

adonispuente added a commit to adonispuente/policies-ui-frontend that referenced this pull request Dec 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant