This repository was archived by the owner on Dec 18, 2025. It is now read-only.
Revert "feat(RHINENG-22427): Remove routing from policies completely …#606
Merged
adonispuente merged 1 commit intoRedHatInsights:masterfrom Dec 12, 2025
Merged
Conversation
…edHatInsights#601)" This reverts commit d745527.
Reviewer's GuideReintroduces frontend CRD configuration for the policies UI by wiring a new OpenShift Template manifest into the fec config, restoring deployment metadata, navigation, and console integration for the Policies frontend. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
Blocking issues:
- Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (link)
General comments:
- In
deploy/frontend.yml, thealt_titlelist containsconditionstwice; consider deduplicating these entries to keep the search metadata clean and intentional. - The analytics
APIKeyis hard-coded in the CRD template; if possible, consider sourcing this from a parameter or secret rather than embedding it directly in the manifest.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `deploy/frontend.yml`, the `alt_title` list contains `conditions` twice; consider deduplicating these entries to keep the search metadata clean and intentional.
- The analytics `APIKey` is hard-coded in the CRD template; if possible, consider sourcing this from a parameter or secret rather than embedding it directly in the manifest.
## Individual Comments
### Comment 1
<location> `deploy/frontend.yml:66` </location>
<code_context>
apRCg9V6oMXCcnTingqRYW6m1er4hkCW
</code_context>
<issue_to_address>
**security (generic-api-key):** Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
*Source: gitleaks*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
adonispuente
added a commit
to adonispuente/policies-ui-frontend
that referenced
this pull request
Dec 12, 2025
…pletely (RedHatInsights#601)" (RedHatInsights#606)" This reverts commit e97b848.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(#601)"
This reverts commit d745527.
Summary by Sourcery
Reintroduce frontend deployment configuration for the policies UI frontend and wire it into the project config.
Deployment: