Skip to content
This repository was archived by the owner on Dec 18, 2025. It is now read-only.

feat(policies): disable FEO flag#607

Merged
adonispuente merged 2 commits intoRedHatInsights:masterfrom
adonispuente:revert2
Dec 12, 2025
Merged

feat(policies): disable FEO flag#607
adonispuente merged 2 commits intoRedHatInsights:masterfrom
adonispuente:revert2

Conversation

@adonispuente
Copy link
Collaborator

@adonispuente adonispuente commented Dec 12, 2025

This reintroduces the removal of FE operator stuff

Summary by Sourcery

Chores:

  • Delete the deprecated frontend Kubernetes manifest and associated configuration path from the build config.

@adonispuente adonispuente requested a review from a team as a code owner December 12, 2025 17:26
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 12, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Reintroduces the previous change that removes the frontend operator routing configuration, including dropping the frontendCRDPath setting and deleting the Kubernetes frontend manifest.

File-Level Changes

Change Details Files
Remove the frontend operator configuration path from the fec configuration.
  • Delete the frontendCRDPath property from the exported configuration object
  • Ensure the module export now only contains the existing fec configuration without CRD-related settings
fec.config.js
Delete the frontend Kubernetes deployment manifest tied to the FE operator.
  • Remove the deploy/frontend.yml file from the repository
  • Eliminate any remaining FE operator deployment definition from version control
deploy/frontend.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Since frontendCRDPath is being removed from fec.config.js, double-check that no build or deployment tooling still expects this property; if any do, consider providing a fallback or updating them in the same change set.
  • With deploy/frontend.yml deleted, verify that any references to this manifest in CI/CD pipelines or Helm/Kustomize configs are updated or removed to avoid runtime deployment errors.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `frontendCRDPath` is being removed from `fec.config.js`, double-check that no build or deployment tooling still expects this property; if any do, consider providing a fallback or updating them in the same change set.
- With `deploy/frontend.yml` deleted, verify that any references to this manifest in CI/CD pipelines or Helm/Kustomize configs are updated or removed to avoid runtime deployment errors.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@adonispuente adonispuente changed the title Revert "Revert "feat(RHINENG-22427): Remove routing from policies com… disable FEO flag Dec 12, 2025
@adonispuente adonispuente changed the title disable FEO flag feat(policies): disable FEO flag Dec 12, 2025
@adonispuente adonispuente merged commit 2d46860 into RedHatInsights:master Dec 12, 2025
3 of 6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant