This repository was archived by the owner on Dec 18, 2025. It is now read-only.
feat(policies): disable FEO flag#607
Merged
adonispuente merged 2 commits intoRedHatInsights:masterfrom Dec 12, 2025
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReintroduces the previous change that removes the frontend operator routing configuration, including dropping the frontendCRDPath setting and deleting the Kubernetes frontend manifest. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Since
frontendCRDPathis being removed fromfec.config.js, double-check that no build or deployment tooling still expects this property; if any do, consider providing a fallback or updating them in the same change set. - With
deploy/frontend.ymldeleted, verify that any references to this manifest in CI/CD pipelines or Helm/Kustomize configs are updated or removed to avoid runtime deployment errors.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `frontendCRDPath` is being removed from `fec.config.js`, double-check that no build or deployment tooling still expects this property; if any do, consider providing a fallback or updating them in the same change set.
- With `deploy/frontend.yml` deleted, verify that any references to this manifest in CI/CD pipelines or Helm/Kustomize configs are updated or removed to avoid runtime deployment errors.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
9773f5c to
723a412
Compare
c4cc5e4 to
bc7ead8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reintroduces the removal of FE operator stuff
Summary by Sourcery
Chores: