fix: properly remove instructions when AGENTS.md is deleted#26
Merged
mrbrandao merged 1 commit intoRedHatProductSecurity:mainfrom Jan 29, 2026
Merged
Conversation
Two issues fixed: 1. remove_instructions() now completely removes the managed section when there are no more module blocks, instead of leaving empty <!-- lola:instructions:start/end --> markers behind. 2. _update_instructions() now always attempts removal when a module no longer has instructions, regardless of what the installation record says. This handles the case where a user reinstalls after deleting AGENTS.md (the old installation record wouldn't have has_instructions=True so removal was never triggered). Includes regression tests for both issues. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remove_instructions()to completely remove the managed section when there are no more module blocks (instead of leaving empty markers)_update_instructions()to always attempt removal when a module no longer has instructions, handling stale installation recordsRelated Issues
Test Plan
test_remove_last_module_cleans_up_markers)test_update_removes_instructions_with_stale_registry)Checklist
pytest)ruff check src tests)ty check)AI Disclosure
AI-assisted with Claude Code (Claude Opus 4.5)