fix: respect content_dirname configuration during module installation#44
Merged
mrbrandao merged 2 commits intoRedHatProductSecurity:mainfrom Feb 12, 2026
Merged
Conversation
Extend _get_content_path() to support both "module" and "lola-module" subdirectories using CONTENT_DIR_CANDIDATES list. This will fix the 🐛 where modules installed with a custom directory were not proper installed. Add _get_content_dirname() helper to extract content path from Module and pass it through all installation functions (_install_skills, _install_commands, _install_agents, _install_instructions, _install_mcps, _run_install_hook). Update _skill_source_dir() to accept optional content_dirname parameter for proper skill resolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content_dirnameconfiguration (e.g.,lola-module/)module/or flat structureRelated Issues
Fixes module installation issue where skills from modules with custom content directories (registered with
--module-content) were not being installed to assistant directories (.claude/,.cursor/, etc.).Test Plan
content_dirname(secdevai withlola-module/).claude/skills/module/subdirectory (test module)Checklist
pytest) - 554 passedruff check src tests)ty check)AI Disclosure
AI-assisted with Claude Code