AND-145: add TextValue #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sx1a9z4f
reviewed
Aug 8, 2024
| @Composable | ||
| @ReadOnlyComposable | ||
| public fun stringResource(text: TextValue): String { | ||
| val resources = resources() |
There was a problem hiding this comment.
Просто ресурсы resources() выносить не имеет смысла,
либо все в return
return resources.getString(text)
либо
val string = resources().getString(text)
return string
Collaborator
There was a problem hiding this comment.
Он вынесен в отдельный метод по аналогии с реализацией оригинального stringResource. Имеет смысл ориентироваться на реализацию из Compose.
Sx1a9z4f
reviewed
Aug 8, 2024
| @Composable | ||
| @ReadOnlyComposable | ||
| private fun resources(): Resources { | ||
| LocalConfiguration.current |
osipxd
requested changes
Aug 9, 2024
| @Composable | ||
| @ReadOnlyComposable | ||
| public fun stringResource(text: TextValue): String { | ||
| val resources = resources() |
Collaborator
There was a problem hiding this comment.
Он вынесен в отдельный метод по аналогии с реализацией оригинального stringResource. Имеет смысл ориентироваться на реализацию из Compose.
osipxd
reviewed
Aug 9, 2024
osipxd
previously approved these changes
Nov 5, 2024
Collaborator
osipxd
left a comment
osipxd
left a comment
There was a problem hiding this comment.
LGTM, one minor comment left
| - [][viewmodelevents-compose] — A set of extensions for dealing with ViewModelEvents inside `@Composable` functions | ||
| - [][viewmodelevents-flow] — An implementation of ViewModelEvents via `Flow` | ||
| - [][viewmodelevents-livedata] — An implementation of ViewModelEvents via `LiveData` | ||
| `ViewModelEvents` addresses the challenge of buffering and consuming one-time events: |
Collaborator
There was a problem hiding this comment.
Suggested change
| `ViewModelEvents` addresses the challenge of buffering and consuming one-time events: | |
| `ViewModelEvents` addresses the challenge of buffering and consuming one-time events. |
TopHlop
requested changes
Jan 20, 2026
AleksandrTabolin
approved these changes
Jan 21, 2026
TopHlop
approved these changes
Jan 21, 2026
Contributor
Author
|
@osipxd, за 1.5 года контекст немного потерялся, по этому комментарию что-то нужно сделать? |
Collaborator
|
Кажется, что можно ничего не править |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.