Skip to content

RF | Refactor CloudsPage to Page Factory #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tstyev merged 1 commit into from
Jan 16, 2026
Merged

RF | Refactor CloudsPage to Page Factory #1861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/test/java/school/redrover/DashboardTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,7 @@
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;
import school.redrover.common.BaseTest;
import school.redrover.page.ArchitectingForScalePage;
import school.redrover.page.CloudsPage;
import school.redrover.page.EditViewPage;
import school.redrover.page.HomePage;
import school.redrover.page.NewNodePage;
import school.redrover.page.*;

import java.util.List;

Expand Down Expand Up @@ -215,7 +211,7 @@ public void testSetUpAgent() {
NewNodePage newNodePage = new HomePage(getDriver())
.clickSetUpAnAgent();

Assert.assertEquals(newNodePage.getHeader().getText(),"New node");
Assert.assertEquals(newNodePage.getHeader().getText(), "New node");
Assert.assertTrue(newNodePage.isFormDisplayed(), "New Node form is not visible");
}

Expand All @@ -225,6 +221,6 @@ public void testConfigureCloudIntegration() {
.clickConfigureCloud();

Assert.assertEquals(cloudsPage.getHeader().getText(), "Clouds");
Assert.assertEquals(cloudsPage.getParagraphText(), "There is no plugin installed that supports clouds.");
Assert.assertEquals(cloudsPage.getCloudsPageInfoText(), "There is no plugin installed that supports clouds.");
}
}
15 changes: 11 additions & 4 deletions src/test/java/school/redrover/page/CloudsPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,20 @@
package school.redrover.page;

import org.openqa.selenium.By;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.WebElement;
import org.openqa.selenium.support.FindBy;
import org.openqa.selenium.support.ui.ExpectedConditions;
import school.redrover.common.BasePage;


public class CloudsPage extends BasePage<CloudsPage> {

@FindBy(tagName = "h1")
private WebElement header;

@FindBy(xpath = "//p")
private WebElement cloudsInfo;

public CloudsPage(WebDriver driver) {
super(driver);
}
Expand All @@ -19,12 +26,12 @@ public CloudsPage getPage() {

@Override
public CloudsPage waitUntilPageLoad() {
getWait5().until(ExpectedConditions.visibilityOf(getDriver().findElement(By.tagName("h1"))));
getWait5().until(ExpectedConditions.visibilityOf(header));

return this;
}

public String getParagraphText() {
return getDriver().findElement(By.xpath("//p")).getText();
public String getCloudsPageInfoText() {
return cloudsInfo.getText();
}
}