RF | Replace the returned WebElement to String on Pages #1870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstyev
approved these changes
Jan 16, 2026
AlexeyKulagin
approved these changes
Jan 16, 2026
| (By.xpath("//button[contains(@style,'inline-flex') and normalize-space()='%s']".formatted(buildStep)))); | ||
| public String verifySentNameIsInFilter(String buildStep) { | ||
| return getWait5().until(ExpectedConditions.visibilityOfElementLocated(By | ||
| .xpath("//button[contains(@style,'inline-flex') and normalize-space()='%s']".formatted(buildStep)))) |
Collaborator
There was a problem hiding this comment.
А тут нельзя да вынести элемент в FindBy?
Collaborator
Author
There was a problem hiding this comment.
Решили, что при переходе на PageFactory "не трогаем форматированные локаторы (%s, .formatted())"
|
|
||
| public WebElement findItem(String itemName) { | ||
| return getDriver().findElement(By.xpath("//a[@href='job/" + itemName + "/']")); | ||
| public String getTextFoundItem(String itemName) { |
Collaborator
There was a problem hiding this comment.
Text должен быть в конце
Collaborator
Author
There was a problem hiding this comment.
ок, поправлю)
| return getWait10().until(ExpectedConditions.visibilityOfElementLocated(By.id("itemname-invalid"))); | ||
| public String getErrorMessageText() { | ||
| return getWait10().until(ExpectedConditions.visibilityOfElementLocated(By | ||
| .id("itemname-invalid"))).getText(); |
Collaborator
There was a problem hiding this comment.
Этот элемент точно можно вынести в в поле
| } | ||
|
|
||
| public WebElement getTextAreaValidationMessage() { | ||
| public String getTextAreaValidationMessage() { |
| return this; | ||
| } | ||
|
|
||
| public String getDisplayNameInStatus() { |
Collaborator
There was a problem hiding this comment.
Rename: getStatusDisplayNameText?
| .gotoHomePage() | ||
| .findItem(MULTIBRANCH_PIPELINE_NAME) | ||
| .getText(); | ||
| .getTextFoundItem(MULTIBRANCH_PIPELINE_NAME); |
|
|
||
| Assert.assertEquals( | ||
| visibleStep.getText(), | ||
| configPage.verifySentNameIsInFilter(buildStep), |
Collaborator
There was a problem hiding this comment.
Мне и кажется это лучше убрать в chain
| .typeIntoFilterBuildStep(buildStep.substring(0, Math.min(5, buildStep.length()))); | ||
|
|
||
| WebElement visibleStep = configPage.verifySentNameIsInFilter(buildStep); | ||
| // WebElement visibleStep = configPage.verifySentNameIsInFilter(buildStep); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1869