Add Pretendo Support + RCE Patches#200
Add Pretendo Support + RCE Patches#200nika5thgearluffy wants to merge 9 commits intoRedShyGuy:masterfrom
Conversation
…-lctrpf" (Just build the local libctrpf and you're good to go)
|
I like the look of that libctrpf workflow! We could definitely integrate it later since I didn’t know you could do this: Even though the build failed and you removed it from the PR, it’s still good to know. (And I’ll certainly use that trick in my own workflows…) However, kwadukathole is currently working on some optimizations over in here so we should wait for that merge before too many conflicts arise from working in this repo 😓 I also think we should wait for the RCE patch to actually be released so we don’t have to deal with updating this integration in case something changes before then. |
|
I saw this coming after reviewing the code but indeed, the build fails because you removed the |
In my end there wasn't a bool argument at all... it was just frdInit(void) for some reason I guess in your end your setup is different, so you can readd the bool arg and test from there since that works for you |
You probably have to update libctru or devkitpro. This workflow uses all the latest libraries from devkitpro. When you do that, please fix the PR |
|
What is this file |
Apparently it's compiled from me compiling libctrpf together from its local folder |
|
Just wanted to chime in, this project is currently licensed under MIT, however our code in Nimbus is licensed under GPLv3. These are not compatible licenses, and any code taken (or derived) from Nimbus needs to be under the GPLv3 license, but I don't see anywhere in this PR where our license was maintained. We ask that the relevant portions of this PR have the license updated to the correct one. Not trying to bust anyones balls here, we've made license-related mistakes too, just pointing it out so it can be corrected before this is merged |
I will make sure the licensing is properly used. Thanks for the notice.🙂 |
Thank you 👍 The actual RCE patches SHOULD all be LGPLv3, which is fully compatible with MIT, but everything else is GPLv3 (and the license headers need to be added even for LGPLv3 works) |
|
Should the patches be moved to another subdirectory? I was thinking about that earlier, just to provide some more organization |
I will organize them later, I guess I will first add them to the new repository. So we don't get any merge conflicts. As I will soon move it all over to this repo |
|
https://github.com/Happynico7504/Vapecord-ACNL-Plugin/releases/tag/v1.0.0 Here... Thank me later... |
This doesn't help us sorry |
but in the meantime people can use this as an alternative... or people who want exactly this version... im not gonna update it ever... i might only fix bugs but nothing more... |
I will release a new beta version today, thank you, but we don't need that :) |
|
As of yesterday, Pretendo has made ACNL online services public again. You can go ahead and merge this if you want to. |
Oh yeaaaaah that's what I was conflicted about. Didn't see any of these messages until just now, my bad |
my one has the license stuff implemented... https://github.com/Happynico7504/Vapecord-ACNL-Plugin/releases/tag/v1.0.0 |
5 participants
This PR adds the Pretendo Nimbus patches which combat the RCE exploit and adds support for Pretendo's new server ID for ACNL.
This mixes the two plugins together, so similar code will be seen in this PR.