Skip to content

fix: added arrow icon to links in footerNavigation #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sabrina-bongiovanni wants to merge 4 commits into
base: v2
Choose a base branch
from
Open

fix: added arrow icon to links in footerNavigation #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77d1a49
fix: added arrow icon to links in footerNavigation
sabrina-bongiovanni Apr 9, 2024
4ac5541
fix: changed styles for footer section title links
sabrina-bongiovanni Apr 10, 2024
4a09351
fix: added parameter to show footer links marker
sabrina-bongiovanni Apr 17, 2024
5cafd5e
fix: used underlined style instead of arrow icon
sabrina-bongiovanni Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
- Sistemato il flag Mostra tipologia bandi nel blocco elenco con variazione Bandi in Evidenza
- Tradotto il messaggio per Screen Reader del bottone per aprire e chiudere il menu in mobile.
- Menu dropdown si chiude correttamente quando il percorso è un sottosito con un menu diverso rispetto al sito principale
- Migliorata l'accessibilità dei link nel footer.

## Versione 7.25.3 (07/03/2024)

Expand Down
3 changes: 3 additions & 0 deletions src/components/ItaliaTheme/Footer/FooterNavigation.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ const FooterNavigation = () => {
);
}, [path, dispatch]);

const markFooterLinks = config.settings.siteProperties.markFooterLinks;

return (
<>
{items && (
Expand All @@ -71,6 +73,7 @@ const FooterNavigation = () => {
title={
intl.formatMessage(messages.goToPage) + ': ' + item.title
}
className={markFooterLinks ? 'underlined' : ''}
>
{item.title}
</Link>
Copy link

@Wagner3UB Wagner3UB Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</Link>
<Link
to={item.url}
title={
intl.formatMessage(messages.goToPage) + ': ' + item.title
}
>
<SectionIcon
section={item.url}
iconProps={{ size: 'sm', color: 'white', className: 'mr-2' }}
/>
{item.title}
<Icon icon="it-arrow-right" color="white" size="sm" />
</Link>

Copy link

@Wagner3UB Wagner3UB Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tranne questo, forse dare una classe al link per il display flex

Expand Down
1 change: 1 addition & 0 deletions src/config/italiaConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ export default function applyConfig(voltoConfig) {
splitMegamenuColumns: true, //se impostato a false, non spezza le colonne con intestazioni nel megamenu
footerNavigationDepth: 2, //valori possibili: [1,2]. Se impostato ad 1 non verranno mostrati nel footer i link agli elementi contenuti nelle sezioni di primo livello.
markSpecialLinks: true, // se impostato a false, non marca con icona i link esterni
markFooterLinks: true, // se impostato a true, viene aggiunta un'icona ai link del footer per renderli riconoscibili
},
appExtras: [
...config.settings.appExtras,
Expand Down
8 changes: 8 additions & 0 deletions theme/bootstrap-override/bootstrap-italia/_footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@

a {
font-weight: 700;

&.underlined {
text-decoration: underline;

&:hover {
text-decoration: none;
}
}
}
}

Expand Down