Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for block categories, thumbnail previews in block selectors, and the ability to disable block selection. Key changes include adding tests for the new block category command, introducing a new trait (CanRenderWithThumbnails) and a RadioButtonImage component for thumbnail rendering, and updating related service providers, commands, and documentation.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/MakeBlockCategoryCommandTest.php | Adds tests to verify the creation of block categories via artisan commands. |
| stubs/category-block.stub | Provides the stub template for generated block category classes. |
| src/Traits/FormatsBlockCategories.php | Offers helper methods for formatting block categories. |
| src/Traits/Commands/CreatesClassFile.php | Enhances file creation for generated classes using stubs. |
| src/Traits/CanRenderWithThumbnails.php | Introduces a trait to manage thumbnail rendering state for components. |
| src/PageBuilderPluginServiceProvider.php | Registers new asset styles and updates command bindings. |
| src/Components/Forms/RadioButtonImage.php | Implements a new field component for displaying block options with thumbnails. |
| src/Components/Forms/PageBuilder.php | Integrates thumbnail rendering into the page builder field component. |
| src/Components/Forms/Actions/SelectBlockAction.php | Updates the select block action to support a thumbnail mode and disables options. |
| src/Commands/CreatePageBuilderPluginBlockCommand.php | Refactors block creation command to use new methods for panel and namespace logic. |
| src/Commands/CreatePageBuilderPluginBlockCategoryCommand.php | Adds a new command for generating block category classes. |
| src/Abstracts/BaseBlockCategory.php | Defines abstract methods for block categories. |
| src/Abstracts/BaseBlock.php | Adds optional methods for block thumbnails and disabling selection. |
| resources/views/forms/radio-button-image.blade.php | Provides a Blade view to render radio button images with category tabs. |
| README.md | Updates documentation to incorporate block categories, thumbnails, and disablement. |
| </div> | ||
| </template> | ||
| @endforeach | ||
| </template> |
There was a problem hiding this comment.
It appears there is an extra closing tag which might cause rendering issues. Please remove this redundant tag.
Suggested change
| </template> |
| - [Parameter injection](#parameter-injection) | ||
| - [Rendering page builder items on infolist](#rendering-page-builder-items-on-infolist) | ||
| - [Rendering page builder item previews on forms](#rendering-page-builder-item-previews-on-forms) | ||
| - [Rendering page builder ite previews on fomrms](#rendering-page-builder-ite-previews-on-fomrms) |
There was a problem hiding this comment.
There are typos in the list item text ('ite' should be 'item' and 'fomrms' should be 'forms'). Please correct the spelling.
Suggested change
| - [Rendering page builder ite previews on fomrms](#rendering-page-builder-ite-previews-on-fomrms) | |
| - [Rendering page builder item previews on forms](#rendering-page-builder-item-previews-on-forms) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.