Merged
Conversation
GigaGiorgadze
requested changes
Sep 9, 2025
Comment on lines
+209
to
+223
| protected function publishGlobalBlockMigration(): void | ||
| { | ||
| $timestamp = now()->format('Y_m_d_His'); | ||
| $migrationName = 'create_global_block_configs_table'; | ||
| $migrationFile = database_path("migrations/{$timestamp}_{$migrationName}.php"); | ||
|
|
||
| $this->createFileFromStub( | ||
| 'create_global_block_configs_table.php', | ||
| $migrationFile, | ||
| [] | ||
| ); | ||
|
|
||
| $this->info("Created migration: {$migrationFile}"); | ||
| $this->warn("Don't forget to run 'php artisan migrate' to create the global_block_configs table."); | ||
| } |
Member
There was a problem hiding this comment.
no need to include this in a command, this can just be republished like other mgirations
Comment on lines
+165
to
+207
| protected function createGlobalBlocksResource(): void | ||
| { | ||
| $resourceNamespace = $this->getClassNameSpaces('Resources'); | ||
| $resourceClass = 'GlobalBlocksResource'; | ||
| $resourceFullClass = $resourceNamespace . '\\' . $resourceClass; | ||
|
|
||
| $this->createFileFromStub( | ||
| 'global-blocks-resource', | ||
| $this->appClassToPath($resourceFullClass), | ||
| [ | ||
| '{{ class }}' => $resourceClass, | ||
| '{{ namespace }}' => $resourceNamespace, | ||
| '{{ resourceNamespace }}' => $resourceNamespace, | ||
| ] | ||
| ); | ||
|
|
||
| $pagesNamespace = $resourceNamespace . '\\' . $resourceClass . '\\Pages'; | ||
|
|
||
| $this->createFileFromStub( | ||
| 'global-blocks-list-page', | ||
| $this->appClassToPath($pagesNamespace . '\\ListGlobalBlocks'), | ||
| [ | ||
| '{{ class }}' => 'ListGlobalBlocks', | ||
| '{{ namespace }}' => $pagesNamespace, | ||
| '{{ resourceClass }}' => $resourceClass, | ||
| '{{ resourceNamespace }}' => $resourceNamespace, | ||
| ] | ||
| ); | ||
|
|
||
| $this->createFileFromStub( | ||
| 'global-blocks-edit-page', | ||
| $this->appClassToPath($pagesNamespace . '\\EditGlobalBlock'), | ||
| [ | ||
| '{{ class }}' => 'EditGlobalBlock', | ||
| '{{ namespace }}' => $pagesNamespace, | ||
| '{{ resourceClass }}' => $resourceClass, | ||
| '{{ resourceNamespace }}' => $resourceNamespace, | ||
| ] | ||
| ); | ||
|
|
||
| $this->info("Created Global Blocks resource at: {$resourceFullClass}"); | ||
| $this->info('The resource has been automatically registered and will appear in your Filament panel navigation.'); | ||
| } |
Member
There was a problem hiding this comment.
regarding this block resource, its better if this resources will be directly on package side,
they can be registered in package provider, in case user will have the need to configure it they can just extend class located inside package.
make registration controllable from outside
Comment on lines
+152
to
+163
| protected function isFirstGlobalBlock(): bool | ||
| { | ||
| $globalBlocksPath = app_path("Filament/{$this->panel->getId()}/Blocks/Globals"); | ||
|
|
||
| if (! is_dir($globalBlocksPath)) { | ||
| return true; | ||
| } | ||
|
|
||
| $existingBlocks = glob($globalBlocksPath . '/*.php'); | ||
|
|
||
| return empty($existingBlocks); | ||
| } |
Member
There was a problem hiding this comment.
i do not think u will need this if u will remove those two function regarding exporting migrations and block resource
GigaGiorgadze
requested changes
Sep 10, 2025
config/page-builder-plugin.php
Outdated
Comment on lines
+8
to
+11
| 'global_blocks' => [ | ||
| 'enabled' => true, | ||
| 'resource' => Redberry\PageBuilderPlugin\Resources\GlobalBlockConfigResource::class, | ||
| ], |
Member
There was a problem hiding this comment.
some apps have multiple panel providers, move this definitions to plugin registration step, so in case someone has multiple panels and want global blocks in only one of them they can configure it without lot of work
GigaGiorgadze
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.