Protect subreddit style checkbox#8
Open
githue wants to merge 1 commit intoReddit-Enhancement-Suite:masterfrom
Open
Protect subreddit style checkbox#8githue wants to merge 1 commit intoReddit-Enhancement-Suite:masterfrom
githue wants to merge 1 commit intoReddit-Enhancement-Suite:masterfrom
Conversation
Author
|
Also forgot to mention it makes the text black and 12px like it was before, instead of gray and smaller. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes honestbleeps/Reddit-Enhancement-Suite#2789
This actually adds quite a few properties because of the amount inherited stuff. The !important declarations should eventually be added inline so they can't be overridden. It's not intended to prevent people from hiding the checkbox, but it should deter them from moving it to the other side of the page or something.
Two subreddits that were incidentally hiding the checkbox were /r/movies and /r/web_design, whereas /r/askreddit was doing something with pseudo elements which is why I added the :before and :after stuff.