Adapt to new expando button design#9
Open
githue wants to merge 1 commit intoReddit-Enhancement-Suite:masterfrom
Open
Adapt to new expando button design#9githue wants to merge 1 commit intoReddit-Enhancement-Suite:masterfrom
githue wants to merge 1 commit intoReddit-Enhancement-Suite:masterfrom
Conversation
Member
|
for quick ref: |
Author
|
Oh that's an older image with a bigger file size, use this one instead:
Forgot to replace the URL in the code. |
Member
|
Thanks for new URL. I added a checklist item for updating that. |
Author
|
Looks like it will change at some point and won't arrive for some time. https://www.reddit.com/r/announcements/comments/4ch0pv/updates_to_our_media_previews/d1i4b1b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes honestbleeps/Reddit-Enhancement-Suite#2738
This is intended to fit over the top of the new expando button CSS that Reddit is currently using in AB testing. It should only be published when reddit switches all users to the new design. If you only want to target users currently using the new design, then you'd need to use JS to detect it.