Improve HNSW-parallel tests - [MOD-7970] #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
==========================================
+ Coverage 96.98% 97.09% +0.10%
==========================================
Files 100 104 +4
Lines 5305 5503 +198
==========================================
+ Hits 5145 5343 +198
Misses 160 160 ☔ View full report in Codecov by Sentry. |
meiravgri
previously approved these changes
Dec 23, 2024
| } | ||
|
|
||
| void printNeighboursOfId(VecSimIndex *index, idType id) const { | ||
| /** |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
meiravgri
approved these changes
Dec 24, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 0.7
git worktree add -d .worktree/backport-576-to-0.7 origin/0.7
cd .worktree/backport-576-to-0.7
git switch --create backport-576-to-0.7
git cherry-pick -x 18afddbb0c095663a50e8b9c41e4079ab720512b |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 0.8
git worktree add -d .worktree/backport-576-to-0.8 origin/0.8
cd .worktree/backport-576-to-0.8
git switch --create backport-576-to-0.8
git cherry-pick -x 18afddbb0c095663a50e8b9c41e4079ab720512b |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 24, 2024
* refactor tests * format * fix helper function * fix range ties (cherry picked from commit 18afddb)
|
Successfully created backport PR for |
GuyAv46
added a commit
that referenced
this pull request
Dec 24, 2024
* refactor tests * format * fix helper function * fix range ties (cherry picked from commit 18afddb)
GuyAv46
added a commit
that referenced
this pull request
Dec 24, 2024
* refactor tests * format * fix helper function * fix range ties (cherry picked from commit 18afddb)
This was referenced Dec 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 24, 2024
Improve HNSW-parallel tests - [MOD-7970] (#576) * refactor tests * format * fix helper function * fix range ties (cherry picked from commit 18afddb) Co-authored-by: GuyAv46 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Refactor tests and improve logging on failure, for better understanding a flakiness in one of the tests.
Mark if applicable