Skip to content

[8.0] Add Arm machines support to benchamrks [MOD-8531]#611

Merged
dor-forer merged 1 commit into8.0from
backport-600-to-8.0
Mar 16, 2025
Merged

[8.0] Add Arm machines support to benchamrks [MOD-8531]#611
dor-forer merged 1 commit into8.0from
backport-600-to-8.0

Conversation

@github-actions
Copy link

Description

Backport of #600 to 8.0.

* Add arm support

* Changed the arm cpu info

* Add ip test

* Add to tests

* Added tests andbm

* fix tests

* Add github benchmakrs

* Check 1

* only arm

* change ami

* Try ireland

* Try different image

* try image

* back to old image

* larger image

* Add option to change env

* back to default region

* Created new image

* Try to add the x86 to check

* Try different machine

* added include

* Try without opti on arm

* Change to c6g

* added matrix region

* change to west

* try the i8

* Try oregon

* Change subnet id

* Now subnet

* Change subnet

* add subnet

* Try group id

* Change to vpc id

* change subnet

* Change ami

* Try without subnet

* add security group again

* Change the subnets

* Change to ids

* Change sg

* psubnet

* Try different

* different

* to a file

* print

* p

* leave empty

* empty

* Try different account

* Run 2 arm machines

* Move both to us-west-2

* Try workflow

* Change name

* Changes

* Change the secrets

* Add supprted arch

* Add defaults

* Support all

* Change the jq

* Change machine to t4g

* Change the name

* Change the machine

* fix the stop

* only benchamrk

* add the secrets

* region secret

* benchmark region

* Change timeout

* Added support for arch name in benchamrks

* change th json

* changed to v9.0

* Change the check

* add v9

* Check alt version of armv9

* added check

* add arc_arch

* changed to CONCAT_WITH_UNDERSCORE_ARCH

* change the check

* Add full check

* fix the instruct

* Added the cmake

* fix the support

* put it back to cmake

* back

* change the condition

* No armpl for now

* cland format

* remove the opt

* Changed to one machine

* Added BENCHMARK_ARCH

* fix endif

* Remove secrets call

* pr changes

* suuport check for armv7

* Change or OR

(cherry picked from commit 977def5)
@GuyAv46 GuyAv46 marked this pull request as draft March 16, 2025 11:23
@GuyAv46 GuyAv46 marked this pull request as ready for review March 16, 2025 11:23
@GuyAv46 GuyAv46 requested a review from dor-forer March 16, 2025 11:24
@codecov
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (9889cd3) to head (0f0a872).
Report is 1 commits behind head on 8.0.

Additional details and impacted files
@@           Coverage Diff           @@
##              8.0     #611   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         106      106           
  Lines        5713     5713           
=======================================
  Hits         5553     5553           
  Misses        160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dor-forer dor-forer added this pull request to the merge queue Mar 16, 2025
Merged via the queue into 8.0 with commit 65fcb7c Mar 16, 2025
11 checks passed
@dor-forer dor-forer deleted the backport-600-to-8.0 branch March 16, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant