Add FP32 Armpl Blas optimization [MOD-9011] #613
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonre24
previously approved these changes
Mar 19, 2025
GuyAv46
reviewed
Mar 24, 2025
|
|
||
| namespace spaces { | ||
|
|
||
| #include "implementation_chooser.h" |
|
|
||
| namespace spaces { | ||
|
|
||
| #include "implementation_chooser.h" |
Comment on lines
54
to
59
| if ((chunk) == 1) { \ | ||
| /* Handle the case where chunk is 0 */ \ | ||
| __ret_dist_func = func<1>; \ | ||
| } else { \ | ||
| switch ((dim) % (chunk)) { CASES##chunk(func) } \ | ||
| } \ |
Collaborator
There was a problem hiding this comment.
Let's revert these changes
GuyAv46
reviewed
Mar 24, 2025
Comment on lines
48
to
49
| // chunk == 1 means that there's no use of the residual, and we can use the function | ||
| // directly. |
GuyAv46
reviewed
Mar 24, 2025
| ASSERT_EQ(arch_opt_func, Choose_FP32_L2_implementation_AVX(dim)) | ||
| << "Unexpected distance function chosen for dim " << dim; | ||
| ASSERT_EQ(baseline, arch_opt_func(v, v2, dim)) << "AVX with dim " << dim; | ||
| ASSERT_EQ(alignment, expected_alignment(256, dim)) << "AVX with dim " << dim; |
GuyAv46
reviewed
Mar 24, 2025
| ASSERT_EQ(arch_opt_func, Choose_FP32_L2_implementation_SSE(dim)) | ||
| << "Unexpected distance function chosen for dim " << dim; | ||
| ASSERT_EQ(baseline, arch_opt_func(v, v2, dim)) << "SSE with dim " << dim; | ||
| ASSERT_EQ(alignment, expected_alignment(128, dim)) << "SSE with dim " << dim; |
GuyAv46
previously approved these changes
Mar 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
A clear and concise description of what the PR is solving.
Which issues this PR fixes
Main objects this PR modified
Mark if applicable