[0.8] Implement optimized FP16 support for ARM architecture - [MOD-9078] #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * implement L2 SVE with intermediate casting to f32 * implement IP SVE with f16 ops only * implements L2 sve with no intermediate casting * add SVE and SVE2 functions files * add new files to cmake and use new implementations * added benchmarks * fix and switch implementation (due to sve2-only op) * test with SVE2 intrinsics * Revert "test with SVE2 intrinsics" This reverts commit 06dd65c. * remove redundant implementation * move to 4 steps per iteration implementations * add macro cleanup * fix implementation * refactor to use 4 accumulators * added tests * refactor accumulation * add initial neon implementation * fix build flags and file layout * fix tests * cleanup and L2 implementation with neon+fp16 * format * fix test for any arch * another attempt * fix test * rename step functions * comment-in neon benchmarks * fix benchmark * review fixes * more review fixes * fixes and cleanup * fix svwhilelt_b16 calls * use vbslq_f16 * typo fix * fix test for OSs that don't support fp16 * added back guards for a specific x86 test (cherry picked from commit fcc8d78)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.8 #644 +/- ##
=======================================
Coverage 96.94% 96.94%
=======================================
Files 91 91
Lines 5069 5069
=======================================
Hits 4914 4914
Misses 155 155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dor-forer
previously approved these changes
Apr 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dor-forer
approved these changes
Apr 7, 2025
dor-forer
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #620 to
0.8.