-
Notifications
You must be signed in to change notification settings - Fork 22
[MOD-11237] Block Size Boundary Oscillation Benchmark #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix counters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
==========================================
+ Coverage 96.82% 96.85% +0.02%
==========================================
Files 122 122
Lines 7496 7496
==========================================
+ Hits 7258 7260 +2
+ Misses 238 236 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| st.counters["memory"] = | ||
| benchmark::Counter((double)VecSimIndex_StatsInfo(index).memory, | ||
| benchmark::Counter::kDefaults, benchmark::Counter::OneK::kIs1024); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 0.6
git worktree add -d .worktree/backport-768-to-0.6 origin/0.6
cd .worktree/backport-768-to-0.6
git switch --create backport-768-to-0.6
git cherry-pick -x fd08b5521ab3b3bdcbe58b6f919ea46a704ecf44 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 0.7
git worktree add -d .worktree/backport-768-to-0.7 origin/0.7
cd .worktree/backport-768-to-0.7
git switch --create backport-768-to-0.7
git cherry-pick -x fd08b5521ab3b3bdcbe58b6f919ea46a704ecf44 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 0.8
git worktree add -d .worktree/backport-768-to-0.8 origin/0.8
cd .worktree/backport-768-to-0.8
git switch --create backport-768-to-0.8
git cherry-pick -x fd08b5521ab3b3bdcbe58b6f919ea46a704ecf44 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.0
git worktree add -d .worktree/backport-768-to-8.0 origin/8.0
cd .worktree/backport-768-to-8.0
git switch --create backport-768-to-8.0
git cherry-pick -x fd08b5521ab3b3bdcbe58b6f919ea46a704ecf44 |
* imp bemchmar fix counters * fix (cherry picked from commit fd08b55)
|
Successfully created backport PR for |
* imp bemchmar fix counters * fix (cherry picked from commit fd08b55)
[MOD-11237] Block Size Boundary Oscillation Benchmark (#768) * imp bemchmar fix counters * fix (cherry picked from commit fd08b55) Co-authored-by: meiravgri <[email protected]>
* imp bemchmar fix counters * fix (cherry picked from commit fd08b55) * add indexCapacity API
Purpose
This PR introduces a new benchmark
UpdateAtBlockSizethat reproduces the allocation/deallocation oscillation issue that occurs when repeatedly updating vectors at block size boundaries. This benchmark demonstrates the performance impact of the problem addressed in PR #753:Problem Being Benchmarked
The benchmark reproduces a scenario where:
blockSize + 1(one element past a block boundary)Implementation Details
Test Coverage: Added to both single and multi-index benchmark suites:
bm_basics_single_fp32.cpp- Single-index scenariosbm_basics_multi_fp32.cpp- Multi-index scenariosBruteForce,HNSW,andTiered HNSWalgorithmsAdditional Changes
Counter Improvements: Enhanced memory-related counters across all benchmarks:
benchmark::Counter::OneK::kIs1024formatting for memory counters to display values in KB units (dividing by 1024 multipliers)Expected Results
index_capandindex_cap - block_sizeon each update cycle