Skip to content

[0.6] Fix incorrect assertion in BM_VecSimBasics::UpdateAtBlockSize benchmark #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meiravgri merged 1 commit into from
Nov 4, 2025
Merged

[0.6] Fix incorrect assertion in BM_VecSimBasics::UpdateAtBlockSize benchmark #826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions tests/benchmark/bm_vecsim_basics.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,17 +193,20 @@ void BM_VecSimBasics<index_type_t>::UpdateAtBlockSize(benchmark::State &st) {
// Benchmark loop: repeatedly delete/add same vector to trigger grow-shrink cycles
labelType label_to_update = curr_label - 1;
size_t index_cap = index->indexCapacity();
std::cout << "index_cap after adding vectors " << index_cap << std::endl;
assert(index_cap == N_VECTORS + vecs_to_blocksize + BM_VecSimGeneral::block_size);

for (auto _ : st) {
// Remove the vector directly from hnsw
size_t ret = VecSimIndex_DeleteVector(index, label_to_update);
assert(ret == 1);
assert(index->indexCapacity() == index_cap - BM_VecSimGeneral::block_size);
// Capacity should shrink by one block after deletion
ret = VecSimIndex_AddVector(index, QUERIES[(added_vec_count - 1) % N_QUERIES].data(),
label_to_update);
assert(ret == 1);
VecSimIndex_DeleteVector(index, label_to_update);

// Capacity should not change
size_t curr_cap = index->indexCapacity();
assert(curr_cap == index_cap);
Comment on lines +204 to +205
Copy link
Collaborator

@GuyAv46 GuyAv46 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call from the assert, so when we build without asserts it will be optimized away (and also to be aligned with other asserts here)

Suggested change
size_t curr_cap = index->indexCapacity();
assert(curr_cap == index_cap);
assert(index->indexCapacity() == index_cap);

VecSimIndex_AddVector(index, QUERIES[(added_vec_count - 1) % N_QUERIES].data(),
label_to_update);
assert(VecSimIndex_IndexSize(index) == N_VECTORS + added_vec_count);
// Capacity should grow back to original size after addition
// Capacity should not change
assert(index->indexCapacity() == index_cap);
}
assert(VecSimIndex_IndexSize(index) == N_VECTORS + added_vec_count);
Expand Down
Loading