Skip to content

Fix SQ8_SQ8 L2 no optimization low dim test for ARM [MOD-13169] #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dor-forer merged 2 commits into from
Jan 7, 2026
Merged

Fix SQ8_SQ8 L2 no optimization low dim test for ARM [MOD-13169] #879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca8ee25
Fix alignment handling in SQ8_SQ8 L2 no optimization test for ARM arc…
dor-forer Jan 6, 2026
d210777
Fix formatting in SQ8_SQ8 L2 no optimization test assertion
dor-forer Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions tests/unit/test_spaces.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2542,12 +2542,19 @@ TEST_F(SpacesTest, SQ8_SQ8_L2_no_optimization_func_test) {

float baseline =
test_utils::SQ8_SQ8_NotOptimized_L2Sqr(v1_quantized.data(), v2_quantized.data(), dim);

unsigned char alignment = 0;
#ifdef CPU_FEATURES_ARCH_AARCH64
// Make sure we don't use any optimization (because there is no size optimization for arm)
auto optimization = getCpuOptimizationFeatures();
optimization.sve = optimization.sve2 = 0;
auto arch_opt_func = L2_SQ8_SQ8_GetDistFunc(dim, &alignment, &optimization);
#else
// Get distance function with nullptr alignment to cover that code path
auto dist_func = L2_SQ8_SQ8_GetDistFunc(dim, nullptr, nullptr);

ASSERT_EQ(dist_func, SQ8_SQ8_L2Sqr) << "Unexpected distance function chosen for dim " << dim;
ASSERT_NEAR(baseline, dist_func(v1_quantized.data(), v2_quantized.data(), dim), 0.001f)
auto arch_opt_func = L2_SQ8_SQ8_GetDistFunc(dim, &alignment, nullptr);
#endif
ASSERT_EQ(arch_opt_func, SQ8_SQ8_L2Sqr)
<< "Unexpected distance function chosen for dim " << dim;
ASSERT_NEAR(baseline, arch_opt_func(v1_quantized.data(), v2_quantized.data(), dim), 0.001f)
<< "SQ8_SQ8_L2Sqr failed to match expected distance";
}

Expand Down
Loading