[MOD-13442] Refactor SQ8 metadata access to use sq8 enum constants #881
+113
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor SQ8 inner product and L2 implementations to
…proved readability
…tants for improved clarity and maintainability
meiravgri
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
=======================================
Coverage 97.13% 97.13%
=======================================
Files 128 129 +1
Lines 7604 7611 +7
=======================================
+ Hits 7386 7393 +7
Misses 218 218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dor-forer
previously approved these changes
Jan 7, 2026
dor-forer
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hardcoded array indices (0, 1, 2, 3) for SQ8 metadata access with
sq8::MIN_VAL,sq8::DELTA,sq8::SUM,sq8::SUM_SQUARESenum values for improved readability and maintainability.