MOD-11322 Adjust to new ASM API

[galcohen-redislabs]

Note

Update slot-ownership logic to use RedisModule_ClusterCanAccessKeysInSlot on OSS and extend redismodule.h with new cluster migration events/structs, keyspace flags, config iterator/get/set, and related APIs wired into init.

• Cluster:
  • Update MR_ClusterIsMySlot to use RedisModule_ClusterCanAccessKeysInSlot on OSS; enterprise uses RedisModule_ShardingGetSlotRange; fallback to cached clusterCtx slot range.
• Module API (redismodule.h):
  • Keyspace notifications: add REDISMODULE_NOTIFY_OVERWRITTEN, REDISMODULE_NOTIFY_TYPE_CHANGED, REDISMODULE_NOTIFY_KEY_TRIMMED; bump _REDISMODULE_NOTIFY_NEXT.
  • Events: add REDISMODULE_EVENT_CLUSTER_SLOT_MIGRATION and ..._TRIM with subevents; expose RedisModuleEvent_ClusterSlotMigration*.
  • Data structs: add RedisModuleSlotRange{,Array}, RedisModuleClusterSlotMigrationInfo, RedisModuleClusterSlotMigrationTrimInfo.
  • Config API: introduce RedisModuleConfigType, RedisModuleConfigIterator and config get/set helpers.
  • Cluster APIs: add RedisModule_ClusterCanAccessKeysInSlot, ...ClusterPropagateForSlotMigration, ...ClusterGetLocalSlotRanges, ...ClusterFreeSlotRanges.
  • Other: add RedisModule_UnsubscribeFromKeyspaceEvents.
  • Wire all new APIs via REDISMODULE_GET_API.

^{Written by Cursor Bugbot for commit 93b1ace. This will update automatically on new commits. Configure here.}

[tezc]

Okay, I wasn't expecting this part in libmr. Thank you for catching it.

Even if we have RedisModule_ClusterCanAccessKeysInSlot(), we may need to use RedisModule_ShardingGetSlotRange() if this is non-asm RE build with Redis 8.4+ :(

Libmr needs to know what kind of clustering is this. I'm not familiar with libmr but I'll try to check it later.
In summary,

• For OSS, we should call RedisModule_ClusterCanAccessKeysInSlot() if it exists. Otherwise, fallback to clusterCtx.minSlot and clusterCtx.maxSlot. (I'm not sure about this yet, perhaps you may have an idea)
• For RE, if this is not OSS clustering, we should call RedisModule_ShardingGetSlotRange(), otherwise, we'll call RedisModule_ClusterCanAccessKeysInSlot(). I'm not sure how libmr can detect this yet.

[galcohen-redislabs]

For now the ask is to adjust to oss cluster only. The adjustments needed for RE with oss-cluster bdbs will come next.
So I'll rely on clusterCtx.isOss for now and will add whatever code is needed for RE ASMs under another ticket.

[tezc]

I see, thanks. Tomorrow, I'll consult others to confirm how we can handle this, maybe we can do something like:

    if (RedisModule_ShardingGetSlotRange) {
        int first_slot, last_slot;
        RedisModule_ShardingGetSlotRange(&first_slot, &last_slot);
        if (first_slot != -1 && last_slot != -1) {  
           /* RE resharding is enabled */
           return first_slot <= slot && last_slot >= slot;
        }
        /* RE sharding is not enabled, try other methods.. */
     }
     
     if (RedisModule_ClusterCanAccessKeysInSlot != NULL)
        return RedisModule_ClusterCanAccessKeysInSlot(slot);
        
    // Fallback.
    return clusterCtx.minSlot <= slot && clusterCtx.maxSlot >= slot;

[tezc]

LGTM! Thanks.

Note: For RE builds, we need adjustment in MR_ClusterIsMySlot() to detect if RE resharding or OSS clustering is used.

[galcohen-redislabs]

LGTM! Thanks.

Note: For RE builds, we need adjustment in MR_ClusterIsMySlot() to detect if RE resharding or OSS clustering is used.

Indeed, but that would be under https://redislabs.atlassian.net/browse/MOD-11623

[CLAassistant]

All committers have signed the CLA.