Skip to content

Fix ci build without code changes#64

Closed
gabsow wants to merge 6 commits intogal-11322-asm-supportfrom
cursor/fix-ci-build-without-code-changes-9758
Closed

Fix ci build without code changes#64
gabsow wants to merge 6 commits intogal-11322-asm-supportfrom
cursor/fix-ci-build-without-code-changes-9758

Conversation

@gabsow
Copy link
Contributor

@gabsow gabsow commented Oct 22, 2025

Fix CI failures by installing necessary Rust toolchain, build dependencies, and OpenSSL on Linux and macOS, and allow unstable Redis matrix to continue on error.

The CI was failing due to missing build tools, Rust toolchain components, and specific library dependencies (like OpenSSL) in the GitHub Actions environment, despite the code building successfully locally. These changes ensure the CI environment has all prerequisites.


Open in Cursor Open in Web


Note

Update CI workflows to install required Rust and system dependencies on Linux/macOS and mark the Redis 'unstable' matrix as continue-on-error.

  • CI (GitHub Actions):
    • Matrix behavior: Set continue-on-error when redis_version is unstable for both linux.yml and macos.yml.
    • Rust setup: Install stable Rust toolchain with clippy and rustfmt on both platforms.
    • Linux (.github/workflows/linux.yml):
      • Install build prerequisites: build-essential, autoconf, automake, libtool, pkg-config, libssl-dev.
    • macOS (.github/workflows/macos.yml):
      • Expand Homebrew installs to include pkg-config and openssl@3; run brew update.
      • Export OPENSSL_PREFIX via $GITHUB_ENV.

Written by Cursor Bugbot for commit f20c603. This will update automatically on new commits. Configure here.

gabsow and others added 2 commits October 22, 2025 21:03
- Ubuntu-latest upgraded from 22.04 to 24.04 (Sept 29, 2025)
- macOS-latest upgraded from Intel to ARM64 macOS 15 (Oct 15, 2025)
- Both changes broke hard-coded libclang paths
- Solution: Use llvm-config to dynamically find libclang paths
- Install llvm/llvm-dev packages on both platforms
- Export LIBCLANG_PATH and LD_LIBRARY_PATH/DYLD_LIBRARY_PATH in all build steps
- Install Rust toolchain with clippy/rustfmt
- Add missing Linux build deps for autotools, pkg-config, OpenSSL
- Install brew openssl@3 and export OPENSSL_PREFIX on macOS
- Mark Redis 'unstable' matrix as allowed-to-fail via continue-on-error
- Keep libclang discovery but ensure env wired for all steps
@cursor
Copy link

cursor bot commented Oct 22, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ gabsow
❌ cursoragent
You have signed the CLA already but the status is still pending? Let us recheck it.

@gabsow gabsow marked this pull request as ready for review October 22, 2025 18:30
- Broaden triggers to any branch for push/PR
- Add workflow_dispatch for manual runs
- Trigger PRs on all branches; only push builds on master
- Add concurrency to cancel in-progress duplicate runs per branch/PR
- Add libtool-bin and m4 to build dependencies
- Bootstrap pip (pip, setuptools, wheel) before installing RLTest
- Build Redis without 'valgrind' make target
@gabsow gabsow force-pushed the gal-11322-asm-support branch 2 times, most recently from f308f66 to 0859b00 Compare October 22, 2025 18:55
- Add OPENSSL_PREFIX=/usr to env for C/C builds linking OpenSSL
- Use apt-get install -y for valgrind step
@gabsow gabsow closed this Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants