Skip to content

Redisversion supported in database create call #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
burythehammer merged 2 commits into from
Aug 6, 2025
Merged

Redisversion supported in database create call #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfdde59
feat: now can get and create pro databases
burythehammer Aug 5, 2025
4e332fe
test: adding further tests for redisversion on get and list
burythehammer Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions database_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ func TestDatabase_Create(t *testing.T) {
"dataPersistence": "none",
"dataEvictionPolicy": "allkeys-lru",
"queryPerformanceFactor": "6x",
"redisVersion": "6.0.5",
"replication": true,
"throughputMeasurement": {
"by": "operations-per-second",
Expand Down Expand Up @@ -96,6 +97,7 @@ func TestDatabase_Create(t *testing.T) {
DataPersistence: redis.String("none"),
DataEvictionPolicy: redis.String("allkeys-lru"),
QueryPerformanceFactor: redis.String("6x"),
RedisVersion: redis.String("6.0.5"),
Replication: redis.Bool(true),
ThroughputMeasurement: &databases.CreateThroughputMeasurement{
By: redis.String("operations-per-second"),
Expand Down Expand Up @@ -138,15 +140,17 @@ func TestDatabase_List(t *testing.T) {
"protocol": "redis",
"provider": "AWS",
"region": "eu-west-1",
"queryPerformanceFactor": "Standard"
"queryPerformanceFactor": "Standard",
"redisVersion": "6.0.5"
},
{
"databaseId": 43,
"name": "second-example",
"protocol": "redis",
"provider": "AWS",
"region": "eu-west-1",
"queryPerformanceFactor": "Standard"
"queryPerformanceFactor": "Standard",
"redisVersion": "6.0.5"
}
]
}
Expand Down Expand Up @@ -178,6 +182,7 @@ func TestDatabase_List(t *testing.T) {
Provider: redis.String("AWS"),
Region: redis.String("eu-west-1"),
QueryPerformanceFactor: redis.String("Standard"),
RedisVersion: redis.String("6.0.5"),
},
{
ID: redis.Int(43),
Expand All @@ -186,6 +191,7 @@ func TestDatabase_List(t *testing.T) {
Provider: redis.String("AWS"),
Region: redis.String("eu-west-1"),
QueryPerformanceFactor: redis.String("Standard"),
RedisVersion: redis.String("6.0.5"),
},
}, actual)

Expand Down Expand Up @@ -216,6 +222,7 @@ func TestDatabase_Get(t *testing.T) {
"value": 10000
},
"QueryPerformanceFactor": "Standard",
"redisVersion": "6.0.5",
"activatedOn": "2020-11-03T09:03:30Z",
"lastModified": "2020-11-03T09:03:30Z",
"publicEndpoint": "example.com:16668",
Expand Down Expand Up @@ -292,6 +299,7 @@ func TestDatabase_Get(t *testing.T) {
Value: redis.Int(10_000),
},
QueryPerformanceFactor: redis.String("Standard"),
RedisVersion: redis.String("6.0.5"),
Clustering: &databases.Clustering{
NumberOfShards: redis.Int(1),
RegexRules: []*databases.RegexRule{
Expand Down
2 changes: 2 additions & 0 deletions service/databases/model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ type CreateDatabase struct {
PortNumber *int `json:"port,omitempty"`
RemoteBackup *DatabaseBackupConfig `json:"remoteBackup,omitempty"`
QueryPerformanceFactor *string `json:"queryPerformanceFactor,omitempty"`
RedisVersion *string `json:"redisVersion,omitempty"`
}

func (o CreateDatabase) String() string {
Expand Down Expand Up @@ -80,6 +81,7 @@ type Database struct {
RedisVersionCompliance *string `json:"redisVersionCompliance,omitempty"`
Backup *Backup `json:"backup,omitempty"`
QueryPerformanceFactor *string `json:"queryPerformanceFactor,omitempty"`
RedisVersion *string `json:"redisVersion,omitempty"`
}

func (o Database) String() string {
Expand Down
Loading