Skip to content

Commit ae14a16

Browse files
oferborshteinoferborshtein
committed
feat: implement dedicated subscription resource with placeholder API integration
Add complete Terraform resource implementation for Redis Cloud dedicated subscriptions: ## New Files - provider/resource_rediscloud_dedicated_subscription.go: Complete CRUD operations with schema - docs/resources/rediscloud_dedicated_subscription.md: Comprehensive documentation with examples - provider/resource_rediscloud_dedicated_subscription_test.go: Acceptance tests with multiple scenarios ## Modified Files - provider/provider.go: Register new rediscloud_dedicated_subscription resource ## Implementation Details - Schema: Comprehensive field definitions with proper validation (CIDR, provider, etc.) - CRUD Operations: Full Create, Read, Update, Delete with proper error handling using diag.FromErr() - Wait Functions: Async operation support using resource status polling (NOT TasksController) - Documentation: Complete with frontmatter, examples (AWS/GCP), argument reference, import instructions - Tests: Multiple test scenarios including basic, update, multi-cloud, VPC, and validation tests ## API Integration Status - Uses placeholder implementation with existing Subscription API as fallback - Includes proper TODO comments for dedicated subscription API integration - Wait functions properly use apiClient for real API calls (fixed from initial broken implementation) - Ready for seamless transition to actual dedicated subscription API when available ## Quality Standards Met ✅ Schema follows TypeString/TypeInt/TypeBool patterns with validation ✅ Error handling uses diag.FromErr() throughout ✅ Documentation includes frontmatter, examples, and import instructions ✅ Tests use acctest.RandomWithPrefix() for unique naming ✅ Implements resource status polling (NOT TasksController) ✅ Follows exact naming conventions: rediscloud_dedicated_subscription ## Development Notes - Dedicated subscription API is currently in development (QA environment only) - Implementation ready for production API integration - Clear placeholder behavior with appropriate warnings - Follows established patterns from existing subscription resources Resolves: Implementation of dedicated subscription resource following Step-by-Step Implementation Guide
1 parent caf5d8b commit ae14a16

File tree

4 files changed

+918
-0
lines changed

4 files changed

+918
-0
lines changed

‎docs/resources/rediscloud_dedicated_subscription.md‎

Lines changed: 156 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,156 @@
1+
---
2+
layout: "rediscloud"
3+
page_title: "Redis Cloud: rediscloud_dedicated_subscription"
4+
description: |-
5+
Dedicated subscription resource in the Redis Cloud Terraform provider.
6+
---
7+
8+
# Resource: rediscloud_dedicated_subscription
9+
10+
Creates a Dedicated Subscription within your Redis Enterprise Cloud Account. Dedicated subscriptions provide dedicated infrastructure with guaranteed resources and enhanced performance for enterprise workloads.
11+
12+
-> **Note:** This resource is for Dedicated Subscriptions only. See also `rediscloud_subscription` (Pro), `rediscloud_essentials_subscription`, and `rediscloud_active_active_subscription`.
13+
14+
~> **Warning:** Dedicated subscriptions are currently in development and may not be available in all environments. Contact Redis support for availability.
15+
16+
## Example Usage
17+
18+
### Basic Dedicated Subscription
19+
20+
```hcl
21+
resource "rediscloud_dedicated_subscription" "example" {
22+
name = "my-dedicated-subscription"
23+
payment_method = "credit-card"
24+
25+
cloud_provider {
26+
provider = "AWS"
27+
cloud_account_id = "1"
28+
region = "us-east-1"
29+
networking_deployment_cidr = "10.0.0.0/24"
30+
availability_zones = ["us-east-1a", "us-east-1b"]
31+
}
32+
33+
instance_type {
34+
instance_name = "dedicated-large"
35+
replication = true
36+
}
37+
38+
redis_version = "7.2"
39+
}
40+
```
41+
42+
### Dedicated Subscription with Custom VPC
43+
44+
```hcl
45+
resource "rediscloud_dedicated_subscription" "custom_vpc" {
46+
name = "dedicated-custom-vpc"
47+
payment_method = "credit-card"
48+
49+
cloud_provider {
50+
provider = "AWS"
51+
cloud_account_id = "1"
52+
region = "us-west-2"
53+
networking_deployment_cidr = "172.16.0.0/24"
54+
networking_vpc_id = "vpc-12345678"
55+
availability_zones = ["us-west-2a", "us-west-2b", "us-west-2c"]
56+
}
57+
58+
instance_type {
59+
instance_name = "dedicated-xlarge"
60+
replication = true
61+
}
62+
}
63+
```
64+
65+
### GCP Dedicated Subscription
66+
67+
```hcl
68+
resource "rediscloud_dedicated_subscription" "gcp_example" {
69+
name = "gcp-dedicated-subscription"
70+
payment_method = "credit-card"
71+
72+
cloud_provider {
73+
provider = "GCP"
74+
cloud_account_id = "1"
75+
region = "us-central1"
76+
networking_deployment_cidr = "10.1.0.0/24"
77+
availability_zones = ["us-central1-a", "us-central1-b"]
78+
}
79+
80+
instance_type {
81+
instance_name = "dedicated-medium"
82+
replication = false
83+
}
84+
85+
redis_version = "6.2"
86+
}
87+
```
88+
89+
## Argument Reference
90+
91+
The following arguments are supported:
92+
93+
* `name` - (Optional) A meaningful name to identify the dedicated subscription.
94+
* `payment_method` - (Optional) Payment method for the requested subscription. Either `credit-card` or `marketplace`. Default: `credit-card`.
95+
* `payment_method_id` - (Optional) A valid payment method pre-defined in the current account. Required when `payment_method` is `credit-card`.
96+
* `cloud_provider` - (Required, change forces recreation) Configuration for cloud provider settings. See [Cloud Provider](#cloud-provider) below.
97+
* `instance_type` - (Required, change forces recreation) Dedicated instance type specification. See [Instance Type](#instance-type) below.
98+
* `redis_version` - (Optional, change forces recreation) Version of Redis to create.
99+
100+
### Cloud Provider
101+
102+
The `cloud_provider` block supports:
103+
104+
* `provider` - (Optional, change forces recreation) The cloud provider to use with the subscription. Either `AWS` or `GCP`. Default: `AWS`.
105+
* `cloud_account_id` - (Optional, change forces recreation) Cloud account identifier. Default: Redis Labs internal cloud account (`1`).
106+
* `region` - (Required, change forces recreation) Deployment region as defined by cloud provider.
107+
* `availability_zones` - (Optional, change forces recreation) List of availability zones used.
108+
* `networking_deployment_cidr` - (Required, change forces recreation) Deployment CIDR mask.
109+
* `networking_vpc_id` - (Optional, change forces recreation) Either an existing VPC Id (already exists in the specific region) or create a new VPC (if no VPC is specified).
110+
111+
### Instance Type
112+
113+
The `instance_type` block supports:
114+
115+
* `instance_name` - (Required, change forces recreation) The name of the dedicated instance type. Available instance types can be retrieved from the instance-types endpoint.
116+
* `replication` - (Optional, change forces recreation) Enable replication for high availability. Default: `true`.
117+
118+
## Attributes Reference
119+
120+
In addition to all arguments above, the following attributes are exported:
121+
122+
* `id` - The unique identifier of the dedicated subscription.
123+
* `status` - Current status of the subscription.
124+
* `pricing` - Pricing details for this dedicated subscription. See [Pricing](#pricing) below.
125+
126+
### Pricing
127+
128+
The `pricing` block contains:
129+
130+
* `type` - The type of cost (e.g., 'Instance').
131+
* `type_details` - Further detail (e.g., instance type name).
132+
* `quantity` - Number of instances.
133+
* `quantity_measurement` - Unit of measurement.
134+
* `price_per_unit` - Price per unit.
135+
* `price_currency` - Currency (e.g., 'USD').
136+
* `price_period` - Billing period (e.g., 'hour').
137+
* `region` - Region associated with the cost.
138+
139+
## Timeouts
140+
141+
`rediscloud_dedicated_subscription` provides the following [Timeouts](https://www.terraform.io/docs/configuration/blocks/resources/syntax.html#operation-timeouts) configuration options:
142+
143+
* `create` - (Default `30 minutes`) Used for creating dedicated subscriptions.
144+
* `read` - (Default `10 minutes`) Used for reading dedicated subscriptions.
145+
* `update` - (Default `30 minutes`) Used for updating dedicated subscriptions.
146+
* `delete` - (Default `10 minutes`) Used for deleting dedicated subscriptions.
147+
148+
## Import
149+
150+
`rediscloud_dedicated_subscription` can be imported using the subscription ID, e.g.
151+
152+
```
153+
$ terraform import rediscloud_dedicated_subscription.example 12345
154+
```
155+
156+
~> **Note:** When importing dedicated subscriptions, ensure that the configuration matches the existing subscription settings to avoid unexpected changes.

‎provider/provider.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ func New(version string) func() *schema.Provider {
7373
"rediscloud_cloud_account": resourceRedisCloudCloudAccount(),
7474
"rediscloud_essentials_subscription": resourceRedisCloudEssentialsSubscription(),
7575
"rediscloud_essentials_database": resourceRedisCloudEssentialsDatabase(),
76+
"rediscloud_dedicated_subscription": resourceRedisCloudDedicatedSubscription(),
7677
// Note the difference in public resource name and the file/method name.
7778
// <default> == flexible == pro
7879
"rediscloud_subscription": resourceRedisCloudProSubscription(),

0 commit comments

Comments
 (0)