Skip to content

Updates the service_attachments to reduce from 40 to 1 #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025
Merged

Updates the service_attachments to reduce from 40 to 1 #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae54e89
Updates the service_attachments to reduce from 40 to 1
trentrosenbaum May 2, 2025
c8637dd
test: updating tests and docs to reflect fewer provider endpoints
burythehammer May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/data-sources/rediscloud_private_service_connect_endpoints.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ The `endpoints` object has these attributes:
* `gcp_vpc_subnet_name` - The GCP Subnet name
* `endpoint_connection_name` - The endpoint connection name
* `status` - The endpoint status
* `service_attachments` - The 40 service attachments that are created for the Private Service Connect endpoint, documented below
* `service_attachments` - The service attachments that are created for the Private Service Connect endpoint, documented below

The `service_attachments` object has these attributes:

Expand Down
4 changes: 2 additions & 2 deletions docs/guides/migration-guide-v1.0.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ resource "rediscloud_subscription" "example" {

alert {
name = "dataset-size"
value = 40
value = 1
}
}
}
Expand Down Expand Up @@ -132,7 +132,7 @@ To use the latest schema, you need to modify the `rediscloud_subscription` resou

alert {
name = "dataset-size"
value = 40
value = 1
}
}
```
Expand Down
2 changes: 1 addition & 1 deletion docs/resources/rediscloud_active_active_private_service_connect_endpoint.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ resource "rediscloud_active_active_subscription_regions" "regions" {
}

locals {
service_attachment_count = 40 # Each rediscloud_active_active_private_service_connect_endpoint will have exactly 40 service attachments
service_attachment_count = 1 # Each rediscloud_active_active_private_service_connect_endpoint will have exactly 1 service attachment
region_id = one([for r in rediscloud_active_active_subscription_regions.regions.region : r.region_id if r.region == var.gcp_region])
}

Expand Down
4 changes: 2 additions & 2 deletions docs/resources/rediscloud_active_active_subscription_database.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ resource "rediscloud_active_active_subscription_database" "database-resource" {
global_source_ips = ["192.168.0.0/16"]
global_alert {
name = "dataset-size"
value = 40
value = 1
}

global_modules = ["RedisJSON"]
Expand Down Expand Up @@ -161,4 +161,4 @@ To update an existing configuration for a database which uses the `memory_limit_
$ terraform state rm rediscloud_active_active_subscription_database.database-resource
(Update the configuration to use `dataset_size_in_gb` instead of `memory_limit_in_gb`)
$ terraform import rediscloud_active_active_subscription_database.database-resource 123456/12345678
```
```
4 changes: 2 additions & 2 deletions docs/resources/rediscloud_private_service_connect_endpoint.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ resource "rediscloud_subscription" "subscription" {
}

locals {
service_attachment_count = 40 # Each rediscloud_private_service_connect_endpoint will have exactly 40 service attachments
service_attachment_count = 1 # Each rediscloud_private_service_connect_endpoint will have exactly 1 service attachment
}

resource "rediscloud_private_service_connect" "service" {
Expand Down Expand Up @@ -195,7 +195,7 @@ module "private_service_connect" {
## Attribute Reference

* `private_service_connect_endpoint_id` - The ID of the Private Service Connect Endpoint
* `service_attachments` - The 40 service attachments that are created for the Private Service Connect endpoint, documented below
* `service_attachments` - The service attachment that is created for the Private Service Connect endpoint, documented below

The `service_attachments` object has these attributes:

Expand Down
4 changes: 2 additions & 2 deletions docs/resources/rediscloud_subscription_database.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ resource "rediscloud_subscription_database" "database-resource" {

alert {
name = "dataset-size"
value = 40
value = 1
}

tags = {
Expand Down Expand Up @@ -171,4 +171,4 @@ To update an existing configuration for a database which uses the `memory_limit_
$ terraform state rm rediscloud_subscription_database.database-resource
(Update the configuration to use `dataset_size_in_gb` instead of `memory_limit_in_gb`)
$ terraform import rediscloud_subscription_database.database-resource 123456/12345678
```
```
2 changes: 1 addition & 1 deletion provider/datasource_rediscloud_pro_subscription_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ resource "rediscloud_active_active_subscription_database" "example" {
global_source_ips = ["192.168.0.0/16", "192.170.0.0/16"]
global_alert {
name = "dataset-size"
value = 40
value = 1
}
override_region {
name = "us-east-1"
Expand Down
8 changes: 4 additions & 4 deletions provider/rediscloud_active_active_database_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func TestAccResourceRedisCloudActiveActiveDatabase_CRUDI(t *testing.T) {
resource.TestCheckResourceAttr(resourceName, "data_eviction", "volatile-lru"),
resource.TestCheckResourceAttr(resourceName, "global_alert.#", "1"),
resource.TestCheckResourceAttr(resourceName, "global_alert.0.name", "dataset-size"),
resource.TestCheckResourceAttr(resourceName, "global_alert.0.value", "40"),
resource.TestCheckResourceAttr(resourceName, "global_alert.0.value", "1"),
resource.TestCheckResourceAttr(resourceName, "global_modules.#", "1"),
resource.TestCheckResourceAttr(resourceName, "global_modules.0", "RedisJSON"),
resource.TestCheckResourceAttr(resourceName, "global_source_ips.#", "2"),
Expand Down Expand Up @@ -294,7 +294,7 @@ resource "rediscloud_active_active_subscription_database" "example" {
global_source_ips = ["192.168.0.0/16", "192.170.0.0/16"]
global_alert {
name = "dataset-size"
value = 40
value = 1
}
global_modules = ["RedisJSON"]
override_region {
Expand Down Expand Up @@ -433,7 +433,7 @@ resource "rediscloud_active_active_subscription_database" "example" {
global_source_ips = ["192.168.0.0/16", "192.170.0.0/16"]
global_alert {
name = "dataset-size"
value = 40
value = 1
}
override_region {
name = "us-east-1"
Expand Down Expand Up @@ -466,7 +466,7 @@ resource "rediscloud_active_active_subscription_database" "example" {
global_source_ips = ["192.168.0.0/16", "192.170.0.0/16"]
global_alert {
name = "dataset-size"
value = 40
value = 1
}
override_region {
name = "us-east-1"
Expand Down
2 changes: 1 addition & 1 deletion provider/rediscloud_active_active_private_service_connect_endpoint_accepter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ resource "google_compute_subnetwork" "subnet" {
}

locals {
service_attachment_count = 40
service_attachment_count = 1
}

resource "google_compute_address" "default" {
Expand Down
2 changes: 1 addition & 1 deletion provider/rediscloud_active_active_private_service_connect_endpoint_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func TestAccResourceRedisCloudActiveActivePrivateServiceConnectEndpoint_CRUDI(t
}
return nil
}),
resource.TestCheckResourceAttr(datasourceName, "endpoints.0.service_attachments.#", "40"),
resource.TestCheckResourceAttr(datasourceName, "endpoints.0.service_attachments.#", "1"),
),
},
{
Expand Down
2 changes: 1 addition & 1 deletion provider/rediscloud_private_service_connect_endpoint_accepter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ resource "google_compute_subnetwork" "subnet" {
}
locals {
service_attachment_count = 40
service_attachment_count = 1
}
resource "google_compute_address" "default" {
Expand Down
2 changes: 1 addition & 1 deletion provider/rediscloud_private_service_connect_endpoint_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func TestAccResourceRedisCloudPrivateServiceConnectEndpoint_CRUDI(t *testing.T)
}
return nil
}),
resource.TestCheckResourceAttr(datasourceName, "endpoints.0.service_attachments.#", "40"),
resource.TestCheckResourceAttr(datasourceName, "endpoints.0.service_attachments.#", "1"),
),
},
{
Expand Down
2 changes: 1 addition & 1 deletion provider/resource_rediscloud_active_active_subscription_regions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ resource "rediscloud_active_active_subscription_database" "example" {
global_password = "%s"
global_alert {
name = "dataset-size"
value = 40
value = 1
}
}
Expand Down
4 changes: 2 additions & 2 deletions provider/resource_rediscloud_pro_database_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func TestAccResourceRedisCloudProDatabase_CRUDI(t *testing.T) {
resource.TestCheckResourceAttr(resourceName, "password", password),
resource.TestCheckResourceAttr(resourceName, "alert.#", "1"),
resource.TestCheckResourceAttr(resourceName, "alert.0.name", "dataset-size"),
resource.TestCheckResourceAttr(resourceName, "alert.0.value", "40"),
resource.TestCheckResourceAttr(resourceName, "alert.0.value", "1"),
resource.TestCheckResourceAttr(resourceName, "modules.#", "1"),
resource.TestCheckResourceAttr(resourceName, "modules.0.name", "RedisBloom"),
resource.TestCheckResourceAttr(resourceName, "enable_default_user", "true"),
Expand Down Expand Up @@ -376,7 +376,7 @@ resource "rediscloud_subscription_database" "example" {

alert {
name = "dataset-size"
value = 40
value = 1
}

modules = [
Expand Down