Skip to content

Add TLS cert to AA DB datasources #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2025
Merged

Add TLS cert to AA DB datasources #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc1ffa6
feat: adding cert to aa db schema
burythehammer Jun 23, 2025
010f4e2
feat: logic for fetching tls certificate from db api
burythehammer Jun 24, 2025
17d91a3
chore: minor renaming
burythehammer Jun 25, 2025
5603ff2
fix: setting string instead of struct
burythehammer Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions provider/datasource_rediscloud_active_active_database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ func dataSourceRedisCloudActiveActiveDatabase() *schema.Resource {
Type: schema.TypeBool,
Computed: true,
},
"tls_certificate": {
Description: "TLS certificate used for authentication.",
Type: schema.TypeString,
Computed: true,
},
"data_eviction": {
Description: "Data eviction items policy",
Type: schema.TypeString,
Expand Down Expand Up @@ -362,9 +367,30 @@ func dataSourceRedisCloudActiveActiveDatabaseRead(ctx context.Context, d *schema
return diag.FromErr(err)
}

if dbTlsCertificate, err := getCertificateData(ctx, api, subId, dbId); err != nil {
return diag.FromErr(err)
} else if dbTlsCertificate != nil {
if err := d.Set("tls_certificate", dbTlsCertificate.PublicCertificatePEMString); err != nil {
return diag.FromErr(err)
}
}

return diags
}

func getCertificateData(ctx context.Context, api *apiClient, subId int, dbId int) (*databases.DatabaseCertificate, error) {
dbTlsCertificate, err := api.client.Database.GetCertificate(ctx, subId, dbId)

if err != nil {
return nil, err
}

if dbTlsCertificate == nil {
return nil, fmt.Errorf("no certificate found for database %d", dbId)
}
return dbTlsCertificate, nil
}

func filterAADatabases(list *databases.ListActiveActiveDatabase, filters []func(db *databases.ActiveActiveDatabase) bool) ([]*databases.ActiveActiveDatabase, error) {
var filtered []*databases.ActiveActiveDatabase
for list.Next() {
Expand Down
2 changes: 2 additions & 0 deletions provider/rediscloud_active_active_database_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ func TestAccResourceRedisCloudActiveActiveDatabase_CRUDI(t *testing.T) {
resource.TestCheckResourceAttr(datasourceName, "support_oss_cluster_api", "false"),
resource.TestCheckResourceAttr(datasourceName, "external_endpoint_for_oss_cluster_api", "false"),
resource.TestCheckResourceAttr(datasourceName, "enable_tls", "false"),
resource.TestCheckResourceAttrSet(datasourceName, "tls_certificate"),

resource.TestCheckResourceAttr(datasourceName, "data_eviction", "volatile-lru"),
resource.TestCheckResourceAttr(datasourceName, "global_modules.#", "1"),
resource.TestCheckResourceAttr(datasourceName, "global_modules.0", "RedisJSON"),
Expand Down