Skip to content

Conversation

@burythehammer
Copy link
Collaborator

@burythehammer burythehammer commented Oct 9, 2025

This PR adds support for the global_enable_default_user attribute to Active-Active database resources, allowing users to control whether the default Redis user is enabled across all regions.

Updates

  • Added global_enable_default_user schema field to resource_rediscloud_active_active_database.go (optional, defaults to true)
  • Updated resource documentation to include the new attribute

Refactoring

  • Refactored support_oss_cluster_api, external_endpoint_for_oss_cluster_api, and data_eviction fields to use conditional GetOk() pattern instead of always setting values
  • Fixed import aliasing for consistency (client2 → client)
  • Fixed minor documentation formatting issues (bullet points, spacing)

Test Improvements

  • Reduced dataset sizes in tests for faster test execution
  • Added a fast failure for Essentials Databases test so they fail fast if any already exist in the account (max of one per RedisCloud account)

API Behaviour Note

The global_enable_default_user field follows a "write-only" pattern - it can be set via the API but is not returned in responses. This means:

  • The field can be configured in Terraform and will be sent to the API during updates
  • The value cannot be read back from the API or used in data sources
  • Terraform tracks the value in state based on user configuration

@burythehammer burythehammer changed the title OPCR-47 add global default user Add global default user Oct 9, 2025
@burythehammer burythehammer force-pushed the OPCR-47-add-global-default-user branch from bd130f2 to 1a460ef Compare October 9, 2025 13:36
@burythehammer burythehammer self-assigned this Oct 9, 2025
@burythehammer burythehammer added the enhancement New feature or request label Oct 9, 2025
Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ The following Jit checks failed to run:

  • secret-detection-trufflehog
  • software-component-analysis-go
  • static-code-analysis-semgrep-pro

#jit_bypass_commit in this PR to bypass, Jit Admin privileges required.

More info in the Jit platform.

@burythehammer burythehammer changed the title Add global default user Add global_enable_default_user support for Active-Active databases Oct 9, 2025
Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ The following Jit checks failed to run:

  • software-component-analysis-go

#jit_bypass_commit in this PR to bypass, Jit Admin privileges required.

More info in the Jit platform.

burythehammer and others added 5 commits October 10, 2025 11:32
Bumps [actions/cache](https://github.com/actions/cache) from 4.2.4 to 4.3.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@0400d5f...0057852)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-version: 4.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.37.0 to 2.38.1.
- [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases)
- [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-plugin-sdk@v2.37.0...v2.38.1)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2
  dependency-version: 2.38.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.5.0 to 6.0.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@d35c59a...4469467)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@burythehammer burythehammer merged commit 34e49b1 into main Oct 10, 2025
17 of 18 checks passed
@burythehammer burythehammer deleted the OPCR-47-add-global-default-user branch October 10, 2025 16:04
burythehammer added a commit that referenced this pull request Nov 10, 2025
Add global_enable_default_user support for Active-Active databases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants