Skip to content

Fixing Database Tests #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Fixing Database Tests #690

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
11ac8b4
test: fixing failing tests
burythehammer Oct 20, 2025
b45d496
test: expectations are standard if the subscription and database leve…
burythehammer Oct 20, 2025
68b55f7
test: changing query performance factor to be in there but only in db…
burythehammer Oct 20, 2025
8eebe69
fix: change error for redis 8 modules to warning
burythehammer Oct 21, 2025
bad7b58
chore: adding debug to essentials db creation
burythehammer Oct 22, 2025
a14286c
chore: go mod dep bump
burythehammer Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 22 additions & 23 deletions provider/pro/testdata/pro_database_data_source.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,39 @@
locals {
rediscloud_cloud_account = "%s"
rediscloud_cloud_account = "%s"
rediscloud_subscription_name = "%s"
rediscloud_password = "%s"
rediscloud_password = "%s"
}

data "rediscloud_payment_method" "card" {
card_type = "Visa"
card_type = "Visa"
last_four_numbers = "5556"
}

data "rediscloud_cloud_account" "account" {
exclude_internal_account = true
provider_type = "AWS"
name = local.rediscloud_cloud_account
provider_type = "AWS"
name = local.rediscloud_cloud_account
}
resource "rediscloud_subscription" "example" {
name = local.rediscloud_subscription_name
name = local.rediscloud_subscription_name
payment_method_id = data.rediscloud_payment_method.card.id
memory_storage = "ram"
memory_storage = "ram"
cloud_provider {
provider = data.rediscloud_cloud_account.account.provider_type
provider = data.rediscloud_cloud_account.account.provider_type
cloud_account_id = data.rediscloud_cloud_account.account.id
region {
region = "eu-west-1"
region = "eu-west-1"
networking_deployment_cidr = "10.0.0.0/24"
preferred_availability_zones = ["eu-west-1a"]
}
}
creation_plan {
memory_limit_in_gb = 1
quantity = 1
replication=false
support_oss_cluster_api=true
throughput_measurement_by = "operations-per-second"
memory_limit_in_gb = 1
quantity = 1
replication = false
support_oss_cluster_api = true
throughput_measurement_by = "operations-per-second"
throughput_measurement_value = 1000
query_performance_factor = "2x"
modules = ["RediSearch"]
}
}
Expand All @@ -47,24 +46,24 @@ resource "rediscloud_subscription_database" "example" {
throughput_measurement_by = "operations-per-second"
throughput_measurement_value = 1000
password = local.rediscloud_password
support_oss_cluster_api = true
replication = false
enable_default_user = true
query_performance_factor = "2x"
redis_version = "7.4"
support_oss_cluster_api = true
replication = false
enable_default_user = true
query_performance_factor = "2x"
redis_version = "7.4"
modules = [
{
name: "RediSearch"
name : "RediSearch"
}
]
}

data "rediscloud_database" "example-by-id" {
subscription_id = rediscloud_subscription.example.id
db_id = rediscloud_subscription_database.example.db_id
db_id = rediscloud_subscription_database.example.db_id
}

data "rediscloud_database" "example-by-name" {
subscription_id = rediscloud_subscription.example.id
name = rediscloud_subscription_database.example.name
name = rediscloud_subscription_database.example.name
}
4 changes: 2 additions & 2 deletions provider/resource_rediscloud_pro_database_qpf_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ func TestAccResourceRedisCloudProDatabase_qpf_missingModule(t *testing.T) {

config := formatDatabaseConfig(name, testCloudAccountName, password, "4x", "")

testErrorCase(t, config, regexp.MustCompile("query_performance_factor\" requires the \"modules\" key to be explicitly defined in HCL"))
testErrorCase(t, config, regexp.MustCompile("DATABASE_QUERY_PERFORMANCE_FACTOR_SEARCH_IS_REQUIRED.*RediSearch.*required"))
}

func TestAccResourceRedisCloudProDatabase_qpf_missingRediSearchModule(t *testing.T) {
Expand All @@ -160,7 +160,7 @@ func TestAccResourceRedisCloudProDatabase_qpf_missingRediSearchModule(t *testing

config := formatDatabaseConfig(name, testCloudAccountName, password, "4x", `modules = [{ name = "RediBloom" }]`)

testErrorCase(t, config, regexp.MustCompile("query_performance_factor\" requires the \"modules\" list to contain \"RediSearch"))
testErrorCase(t, config, regexp.MustCompile("DATABASE_QUERY_PERFORMANCE_FACTOR_SEARCH_IS_REQUIRED.*RediSearch.*required"))
}

func TestAccResourceRedisCloudProDatabase_qpf_invalidQueryPerformanceFactors(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion provider/resource_rediscloud_pro_database_redis_8_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func TestAccResourceRedisCloudProDatabase_Redis8_Upgrade(t *testing.T) {
Check: resource.ComposeAggregateTestCheckFunc(
resource.TestCheckResourceAttr(resourceName, "name", "example"),
resource.TestCheckResourceAttr(resourceName, "protocol", "redis"),
resource.TestCheckResourceAttr(resourceName, "dataset_size_in_gb", "3"),
resource.TestCheckResourceAttr(resourceName, "dataset_size_in_gb", "1"),
resource.TestCheckResourceAttr(resourceName, "replication", "false"),
resource.TestCheckResourceAttr(resourceName, "support_oss_cluster_api", "false"),
resource.TestCheckResourceAttr(resourceName, "resp_version", "resp3"),
Expand Down
Loading