Skip to content

Disable default features on nix crate#414

Merged
oshadmi merged 1 commit intoRedisLabsModules:masterfrom
hdoordt:eliminate-memfd
Aug 27, 2025
Merged

Disable default features on nix crate#414
oshadmi merged 1 commit intoRedisLabsModules:masterfrom
hdoordt:eliminate-memfd

Conversation

@hdoordt
Copy link
Contributor

@hdoordt hdoordt commented Apr 9, 2025

This PR disables the default features on the nix crate. Enabling default features makes nix, and therefore anything using redis-module, require at least glibc >= 2.27 as it'll contain a reference to e.g. memfd_create. For instance, Amazon Linux 2 ships with glibc 2.26 and does not work with default features enabled.

No features are actually used by redis-module.

@DvirDukhan
Copy link

@ephraimfeldblum LMK if it works for JSON

@ephraimfeldblum
Copy link
Contributor

ephraimfeldblum commented Apr 9, 2025

@DvirDukhan sure, no reason why JSON would object.

nix is only being used by redismodule to write to a raw fd in the event that the RedisAllocator is unavailable. write has be standardized since POSIX.1, I doubt you'll find an arch that doesn't support it.

@hdoordt
Copy link
Contributor Author

hdoordt commented Apr 14, 2025

@ephraimfeldblum @DvirDukhan Are we ready to merge this one?

@oshadmi oshadmi merged commit 71ab433 into RedisLabsModules:master Aug 27, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants