-
Notifications
You must be signed in to change notification settings - Fork 77
MOD-8720 command proc macro: add acl and command arguments parameters #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimfeldblum
previously approved these changes
Nov 11, 2025
ephraimfeldblum
approved these changes
Nov 11, 2025
AvivDavid23
added a commit
that referenced
this pull request
Nov 11, 2025
MOD-8720 command proc macro: add acl and command arguments parameters (cherry picked from commit f65b1db)
AvivDavid23
added a commit
that referenced
this pull request
Nov 11, 2025
Merge pull request #432 from RedisLabsModules/MOD-8720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds proc-macro and runtime support for declaring command argument specs and ACL categories, and moves AclCategory to a new common crate.
redismodule-rs-macros):redis_command!proc-macro: acceptsargs(typed arg specs with flags/subargs) andacl_categories; generatesCommandInfowithcommand_argsand ACL categories.src/context/commands.rs):CommandArgFlags,RedisModuleCommandArg, conversion to raw, and memory free helpers; exposeget_redis_command_args.CommandInfoto includeargsand optionalacl_categories; set viaRedisModule_SetCommandInfoandRedisModule_SetCommandACLCategories.AclCategoryto newcommoncrate and re-export fromsrc/lib.rs; remove old definition fromsrc/context/mod.rs.redis_module!macrocommandssection optional and adjust command registration usage.commoncrate dependency to workspace and macros crate.Written by Cursor Bugbot for commit 8908078. This will update automatically on new commits. Configure here.