feat: add RedisKey::name_raw method
#436
Open
+22
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the `RedisKey::name_raw` method which allows access to the raw `RedisModuleString` name of this key.
GlenDC
approved these changes
Dec 10, 2025
|
|
||
| /// # Panics | ||
| /// | ||
| /// Will panic if `RedisModule_ModuleTypeGetValue` is missing in redismodule.h |
There was a problem hiding this comment.
Why is that a panic and not a compile error?
Author
There was a problem hiding this comment.
dynamic linking, a redis module is compiled into a cdylib that links dynamically against the module API exposed by the redis server. We therefore have to unwrap on the dynamic library function pointer (bc it might not exist)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
RedisKey::name_rawmethod which allows access to the rawRedisModuleStringname of this key.