fix: enhance unevaluatedProperties handling for composite rules

[vadyvas]

What issue does this pull request resolve?

fix for: redocly cli #1737

What changes did you make?

Changes in unevaluatedProperties.ts to skip the forced static check in anyOf/oneOf. This removes false unevaluatedProperties errors and allows schema to pass validly with the current example:

const schema = {
  type: "object",
  properties: {
    address: {type: "string"},
  },
  anyOf: [
    {
      type: "object",
      required: ["firstName", "lastName"],
      properties: {
        firstName: {type: "string"},
        lastName: {type: "string"},
      },
    },
    {
      type: "object",
      required: ["name"],
      properties: {
        name: {type: "string"},
      },
    },
  ],
};

const data = {
  address: "someWhere",
  firstName: "John",
  lastName: "Doe",
};

ajv.validate(schema, data); // should be true

Is there anything that requires more attention while reviewing?

[vadyvas]

In composite rules run static check only when schema explicitly provides unevaluatedProperties

[vadyvas]

Skip forced static check under composite rules (anyOf/oneOf)

[vadyvas]

tested in redocly-cli and monorepo. all tests pass

[RomanHotsiy]

👍 LGTM

[RomanHotsiy]

Does original AJV has the same problem if the unevaludatedProperties is added to the root schema? Consider contributing to their repo if it does.

Did you also run ajv tests?

[vadyvas]

@RomanHotsiy

Does original AJV has the same problem if the unevaludatedProperties is added to the root schema? Consider contributing to their repo if it does.

No, the issue doesn’t reproduce in the original AJV (see screenshots below).
The error is caused by our “forced” check of unevaluatedProperties inside a branch, which doesn’t exist in the original repo. Therefore, a contribution to the AJV repo isn’t needed

Did you also run ajv tests?

yes, all pass