chore: remove NPM_TOKEN and bundle publishing step in workflow #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatomyr
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
The
publishGitHub Actions workflow is currently failing in CI because it depends on theNPM_TOKENsecret and tries to commit bundles to theajv-distrepository. In our setup we use npm Trusted Publisher for authentication, which does not require anNPM_TOKEN.What changes did you make?
NPM_TOKENsecret in thePublish to npmstep, since npm Trusted Publisher is used instead and does not require a token.ajv-distrepository from the workflow.ajv-diststep commented out for future reference, in case we decide to reintroduce bundle publishing later.Is there anything that requires more attention while reviewing?
-