Fix/validation required warning with readonly writeonly props v2 #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD:
What issue does this pull request resolve?
Fixes false validation warnings/errors when required is combined with
readOnly/writeOnlyin OpenAPI schemas—especially forrequest/responseexamples where:This matches the real-world “single schema for input/output” use case described in validation of sample : readOnly / writeOnly and required statement interaction redocly-cli#1416.
What changes did you make?
lib/vocabularies/validation/readOnly.tslib/vocabularies/validation/writeOnly.tslib/vocabularies/validation/index.tsreadOnly/writeOnlyfromlib/vocabularies/metadata.tsso they don’t get treated as “annotation-only” -metadata (which would block validation behavior).readOnly: true properties in request contextwriteOnly: true properties in response contextIs there anything that requires more attention while reviewing?
{ oas: { mode: 'request' | 'response', location? } }. Without it, behavior stays as before.