fix: enable path parsing to account for root level paths#1638
fix: enable path parsing to account for root level paths#1638LukasParke wants to merge 19 commits intoRedocly:mainfrom
Conversation
🦋 Changeset detectedLatest commit: aa943dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for the pull request @LukeHagar , we'll take a look. |
|
@LukeHagar do you mind adding a simple e2e test for the case? |
|
I'd be happy too, I realize this solution would also collide with any API endpoints that are actually |
|
@lornajane @tatomyr I think this is right. I couldn't get any of the tests to run locally due to a warning about an outdated dep messing with the snapshot output |
It's most likely because you're using Node version 21 or higher. If you try version 20 or earlier, it should work locally. |
|
Yup I'm on |
There was a problem hiding this comment.
Does this mean that it will create a file named ~root for the root path?
There was a problem hiding this comment.
I believe the best solution here would be simply returning the pathSeparator.
@LukeHagar, let me know if are still interested in the PR, or I'll redo this myself.
There was a problem hiding this comment.
Swapped it over, but I do think there could be a better solution here, as a root level endpoint is somewhat common.
There was a problem hiding this comment.
You might be right, but I haven't come up with a better solution yet. Let's start small and will see how it goes.
|
Could you rebase your branch as I believe smoke tests are failing due to the outdated code? |
|
I'll rebase when I get on this morning |
|
@LukeHagar it looks like it's too much to rebase. As for me, it'd be simpler to reapply your changes from scratch. |
|
Any updates @LukeHagar 🙂? |
|
Closing this since I've moved the logic manually to #2485. |
What/Why/How?
Fixes #1634
Reference
Testing
Screenshots (optional)
Check yourself
Security