fix: expand glob before checking API count in join #1757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9f8b6b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
Thanks @NeelChotai! I'll review your PR once I have time. |
tatomyr
reviewed
Dec 6, 2024
HCloward
approved these changes
Dec 6, 2024
Co-authored-by: Andrew Tatomyr <[email protected]>
tatomyr
approved these changes
Dec 6, 2024
Collaborator
tatomyr
left a comment
tatomyr
left a comment
There was a problem hiding this comment.
Nice fix, thanks! Your changes will be included in the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Fixes #1196.
Reference
Testing
Tested locally in
/bin/shenv and works where it was previously failing.Screenshots (optional)
Check yourself
Security