Skip to content

Conversation

@tatomyr
Copy link
Collaborator

@tatomyr tatomyr commented Nov 20, 2024

What/Why/How?

The check inside isAuthorizedWithRedocly was incorrect. We were checking for objects, but the argument is actually an array.

Reference

Fixes #1805

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@tatomyr tatomyr requested review from a team as code owners November 20, 2024 13:44
@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: 8500fb6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tatomyr tatomyr self-assigned this Nov 20, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 988.1 ± 27.2 969.6 1062.6 1.02 ± 0.03
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 965.8 ± 13.2 941.5 987.0 1.00

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.83% 5016/6363
🟡 Branches 67.53% 2076/3074
🟡 Functions 73.32% 830/1132
🟡 Lines 79.14% 4734/5982

Test suite run success

812 tests passing in 121 suites.

Report generated by 🧪jest coverage report action from 8500fb6

@tatomyr tatomyr requested a review from Marshevskyy November 20, 2024 13:47
@Marshevskyy Marshevskyy merged commit 884ca34 into main Nov 20, 2024
39 checks passed
@Marshevskyy Marshevskyy deleted the fix/correctly-check-authorization branch November 20, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deprecate preview-docs command

4 participants