Skip to content

Conversation

@DmitryAnansky
Copy link
Contributor

What/Why/How?

Reduce recommended npm version to 9.5 as it has a number of security fixes and compatible with recommended node js version.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 794359c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DmitryAnansky DmitryAnansky force-pushed the chore/reduce-recomendation-for-npm-version branch from d727cc5 to 794359c Compare February 5, 2025 09:34
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 973.7 ± 10.9 957.5 990.2 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 981.9 ± 20.7 958.3 1032.3 1.01 ± 0.02

@DmitryAnansky DmitryAnansky marked this pull request as ready for review February 5, 2025 09:35
@DmitryAnansky DmitryAnansky requested a review from a team as a code owner February 5, 2025 09:35
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.6% 5053/6429
🟡 Branches 67.18% 2059/3065
🟡 Functions 73.16% 834/1140
🟡 Lines 78.88% 4767/6043

Test suite run success

836 tests passing in 120 suites.

Report generated by 🧪jest coverage report action from 794359c

Copy link
Collaborator

@tatomyr tatomyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use any specific npm version in smoke tests? Maybe we have to add it to test there?

@DmitryAnansky
Copy link
Contributor Author

Do we use any specific npm version in smoke tests? Maybe we have to add it to test there?

no - we only point nodeJS version like this

        with:
          node-version: 22

and correspondent version of npm installed.
I don't think we should change this.

@DmitryAnansky DmitryAnansky requested a review from tatomyr February 5, 2025 10:27
@DmitryAnansky DmitryAnansky merged commit da8f032 into main Feb 5, 2025
43 of 44 checks passed
@DmitryAnansky DmitryAnansky deleted the chore/reduce-recomendation-for-npm-version branch February 5, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants