Skip to content

Conversation

@jeylost
Copy link

@jeylost jeylost commented Feb 7, 2025

What/Why/How?

This PR aims to address CVE-2024-55565.
styled-components has released version 6.1.15 with the fix.

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@jeylost jeylost requested a review from a team as a code owner February 7, 2025 16:16
@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: 4c71f84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 950.3 ± 14.3 931.0 975.2 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 969.1 ± 16.3 949.7 998.1 1.02 ± 0.02

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.6% 5053/6429
🟡 Branches 67.18% 2059/3065
🟡 Functions 73.16% 834/1140
🟡 Lines 78.88% 4767/6043

Test suite run success

836 tests passing in 120 suites.

Report generated by 🧪jest coverage report action from 4c71f84

@jeylost
Copy link
Author

jeylost commented Feb 7, 2025

Should the bumping of a package be included in the package changeset?

@tatomyr
Copy link
Collaborator

tatomyr commented Feb 7, 2025

@jeylost no, it's not needed I think. I'll ignore that.
However, the tests are failing due to snapshot size changes (which is expected, but we've just released a broken version because of assuming it's expected, so it's better to test it separately). Let's check that case offline.

@jeylost jeylost force-pushed the chore/bump-styled-components branch from 364a256 to 4c71f84 Compare February 10, 2025 12:46
@jeylost jeylost added the snapshot Create experimental release PR label Feb 10, 2025
@jeylost jeylost closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changeset needed snapshot Create experimental release PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants