Skip to content

chore: implement respect_max_steps#1945

Merged
RomanHotsiy merged 6 commits intofeat/introduce-respectfrom
adjust-flow
Feb 24, 2025
Merged

chore: implement respect_max_steps#1945
RomanHotsiy merged 6 commits intofeat/introduce-respectfrom
adjust-flow

Conversation

@RomanHotsiy
Copy link
Member

@RomanHotsiy RomanHotsiy commented Feb 24, 2025

What/Why/How?

Introduce MAX_STEPS env variable.

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 032a4a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 79.21% 6929/8748
🟡 Branches 68.2% 2867/4204
🟡 Functions 74.98% 1139/1519
🟡 Lines 79.57% 6604/8300
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / spot-supported-versions.ts
 100% 100% 100% 100%
🟢
... / no-criteria-xpath.ts
 100% 100% 100% 100%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟢
... / run-step.ts
92.48% (-1.22% 🔻)
 88.61% 100%
92.25% (-1.25% 🔻)

Test suite run success

1323 tests passing in 189 suites.

Report generated by 🧪jest coverage report action from 032a4a3

@DmitryAnansky DmitryAnansky self-requested a review February 24, 2025 12:17
@RomanHotsiy RomanHotsiy marked this pull request as ready for review February 24, 2025 12:32
@RomanHotsiy RomanHotsiy requested a review from a team as a code owner February 24, 2025 12:32
@RomanHotsiy RomanHotsiy merged commit f3b09eb into feat/introduce-respect Feb 24, 2025
34 of 35 checks passed
@RomanHotsiy RomanHotsiy deleted the adjust-flow branch February 24, 2025 12:33
DmitryAnansky added a commit that referenced this pull request Feb 24, 2025
@github-actions @DmitryAnansky
@RomanHotsiy @tatomyr
chore: 🧪 release (feat: wip, introduce "respect") (#1947)
83882ff 
* feat: add respect to cli

* chore: prettier

* chore: changes to e2e and rename to respect-core

* feat: remove respect auth

* fix: add ignored module

* chore: add files

* fix: type issue in utils

* fix: update all e2e tests

* chore: renaming

* chore: fix and simplify go-to logic

* chore: fix lint and unit tests

* chore: fix e2e for new goto

* chore: fix scripts to support respect-core

* fix parser:generate

* chore: rename ResultObject type

* chore: remove todos

* chore: sync package-lock

* chore: fix some lint errors

* chore: add secret

* chore: prettier fix

* chore: add abnf-parser to prettierignore

* chore: publish respect-core snaphot to npm

* chore: comment ignored e2e snapshot and update regexp

* fix: update cert regexp

* chore: try fixing publish and yarn smokes

* chore: try fixing publish

* chore: try fixing publish and remove smokes for node 14 and 16

* chore: fix docker smoke test

* chore: improve README and CONTRIBUTING files

* fix: cookies from workflows and step are not set to the request (#1918)

* chore: update respect command handler (#1920)

* fix: the $file decorator resolves wrong path to the file (#1921)

* chore: improve performance (#1924)

* fix: kebab case command options & mtls path & remove residensy (#1925)

* chore: cleanup resources folder (#1926)

* fix: revert dynamic imports

* chore: add dynamic import back

* chore: rename workflowId to workflowName and also targetWorkflow (#1927)

* chore: rename workflowId to workflowName and also targetWorkflow

* chore: fix tests and move outputs calc lower

* chore: run prettier

* Update packages/respect-core/src/modules/flow-runner/call-api-and-analyze-results.ts

Co-authored-by: Andrew Tatomyr <andrew.tatomyr@redocly.com>

---------

Co-authored-by: Andrew Tatomyr <andrew.tatomyr@redocly.com>

* chore: update package lock (#1929)

* feat: remove extendend option from generate-arazzo command (#1930)

* chore: fix e2e snapshots escape seq

* chore: simplify nested workflows output and flow

* chore: verbose flag was lost for nested workflows (#1934)

* chore: refactor types, descriptions and names (#1932)

* chore: improve tests (#1935)

* feat: resolve server url (#1936)

* chore: implement new json output and improve counting of steps

* chore: use json server test (#1937)

* chore: improve performance (#1941)

* feat: changes to success criteria checks display (#1943)

* feat: changes to success criteria checks display

* chore: update smoke snapshot

* chore: make check display function

* chore: update name

* chore: update smoke

* chore: update smoke again

---------

Co-authored-by: Roman Hotsiy <gotsijroman@gmail.com>

* chore: fix default failure action

* chore: adjust license and readme

* chore: rename cli rules (#1946)

* chore: implement respect_max_steps (#1945)

* chore: implement respect_max_steps

* chore: remove recors from fake-db

* chore: fix git ignore

* chore: update e2e snapshot

* chore: fix json logs

* chore: fix types

---------

Co-authored-by: DmitryAnansky <dmytro@redocly.com>

* chore: fix body always present

* chore: change max steps to 2000

* chore: rename env var

* chore: fix prettier

* chore: fix unknown step + tests

* chrore: fix json output data

---------

Co-authored-by: DmitryAnansky <dmytro@redocly.com>
Co-authored-by: Roman Hotsiy <gotsijroman@gmail.com>
Co-authored-by: Andrew Tatomyr <andrew.tatomyr@redocly.com>
Co-authored-by: Roman Hotsiy <roman@redocly.com>
DmitryAnansky added a commit that referenced this pull request Feb 25, 2025
@github-actions @DmitryAnansky
@RomanHotsiy @tatomyr
chore: 🧪 release (feat: wip, introduce "respect") (#1951)
776f59d 
* feat: add respect to cli

* chore: prettier

* chore: changes to e2e and rename to respect-core

* feat: remove respect auth

* fix: add ignored module

* chore: add files

* fix: type issue in utils

* fix: update all e2e tests

* chore: renaming

* chore: fix and simplify go-to logic

* chore: fix lint and unit tests

* chore: fix e2e for new goto

* chore: fix scripts to support respect-core

* fix parser:generate

* chore: rename ResultObject type

* chore: remove todos

* chore: sync package-lock

* chore: fix some lint errors

* chore: add secret

* chore: prettier fix

* chore: add abnf-parser to prettierignore

* chore: publish respect-core snaphot to npm

* chore: comment ignored e2e snapshot and update regexp

* fix: update cert regexp

* chore: try fixing publish and yarn smokes

* chore: try fixing publish

* chore: try fixing publish and remove smokes for node 14 and 16

* chore: fix docker smoke test

* chore: improve README and CONTRIBUTING files

* fix: cookies from workflows and step are not set to the request (#1918)

* chore: update respect command handler (#1920)

* fix: the $file decorator resolves wrong path to the file (#1921)

* chore: improve performance (#1924)

* fix: kebab case command options & mtls path & remove residensy (#1925)

* chore: cleanup resources folder (#1926)

* fix: revert dynamic imports

* chore: add dynamic import back

* chore: rename workflowId to workflowName and also targetWorkflow (#1927)

* chore: rename workflowId to workflowName and also targetWorkflow

* chore: fix tests and move outputs calc lower

* chore: run prettier

* Update packages/respect-core/src/modules/flow-runner/call-api-and-analyze-results.ts

Co-authored-by: Andrew Tatomyr <andrew.tatomyr@redocly.com>

---------

Co-authored-by: Andrew Tatomyr <andrew.tatomyr@redocly.com>

* chore: update package lock (#1929)

* feat: remove extendend option from generate-arazzo command (#1930)

* chore: fix e2e snapshots escape seq

* chore: simplify nested workflows output and flow

* chore: verbose flag was lost for nested workflows (#1934)

* chore: refactor types, descriptions and names (#1932)

* chore: improve tests (#1935)

* feat: resolve server url (#1936)

* chore: implement new json output and improve counting of steps

* chore: use json server test (#1937)

* chore: improve performance (#1941)

* feat: changes to success criteria checks display (#1943)

* feat: changes to success criteria checks display

* chore: update smoke snapshot

* chore: make check display function

* chore: update name

* chore: update smoke

* chore: update smoke again

---------

Co-authored-by: Roman Hotsiy <gotsijroman@gmail.com>

* chore: fix default failure action

* chore: adjust license and readme

* chore: rename cli rules (#1946)

* chore: implement respect_max_steps (#1945)

* chore: implement respect_max_steps

* chore: remove recors from fake-db

* chore: fix git ignore

* chore: update e2e snapshot

* chore: fix json logs

* chore: fix types

---------

Co-authored-by: DmitryAnansky <dmytro@redocly.com>

* chore: fix body always present

* chore: change max steps to 2000

* chore: rename env var

* chore: fix prettier

* chore: fix unknown step + tests

* chrore: fix json output data

* chore: remove skipped column in workflow result table (#1948)

* fix: server selection by index (#1949)

* chore: fix json output types

* fix: replacement value evaluation (#1950)

* fix: revert warning level test

---------

Co-authored-by: DmitryAnansky <dmytro@redocly.com>
Co-authored-by: Roman Hotsiy <gotsijroman@gmail.com>
Co-authored-by: Andrew Tatomyr <andrew.tatomyr@redocly.com>
Co-authored-by: Roman Hotsiy <roman@redocly.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DmitryAnansky DmitryAnansky Awaiting requested review from DmitryAnansky

Assignees

No one assigned

Labels

no changeset needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RomanHotsiy @DmitryAnansky @tatomyr