Skip to content

chore: add @redocly/config to @redocly/cli dependencies#1960

Merged
tatomyr merged 1 commit intoRedocly:mainfrom
dfrankland:fix-missing-cli-dep
Feb 27, 2025
Merged

chore: add @redocly/config to @redocly/cli dependencies#1960
tatomyr merged 1 commit intoRedocly:mainfrom
dfrankland:fix-missing-cli-dep

Conversation

@dfrankland
Copy link
Contributor

@dfrankland dfrankland commented Feb 26, 2025

What/Why/How?

@redocly/cli was missing a dependency on @redocly/config. This adds that dependency so that installing and using @redocly/cli using tools like pnpm won't fail. Specifically, this is when hoisting is not enabled: https://pnpm.io/npmrc#hoist

Reference

import { deprecatedRefDocsSchema } from '@redocly/config/lib/reference-docs-config-schema';

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@dfrankland dfrankland requested a review from a team as a code owner February 26, 2025 00:43
@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: 0b032a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tatomyr tatomyr changed the title add @redocly/config to @redocly/cli dependencies chore: add @redocly/config to @redocly/cli dependencies Feb 26, 2025
Copy link
Collaborator

@tatomyr tatomyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dfrankland for the PR! I've missed it and updated the config package version in packages/core. Could you rebase your branch and resolve the conflicts?

Please disregard the checks failure.

@dfrankland
Copy link
Contributor Author

@tatomyr no problem at all. Updated, rebased, and pushed 👍

@tatomyr tatomyr force-pushed the fix-missing-cli-dep branch from d38f991 to 0b032a8 Compare February 27, 2025 09:50
Copy link
Collaborator

@tatomyr tatomyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@tatomyr tatomyr merged commit 54b462e into Redocly:main Feb 27, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants