Skip to content

chore: add a precommit hook and improve smoke tests#1963

Merged
Marshevskyy merged 4 commits intomainfrom
chore/add-precommit
Feb 27, 2025
Merged

chore: add a precommit hook and improve smoke tests#1963
Marshevskyy merged 4 commits intomainfrom
chore/add-precommit

Conversation

@tatomyr
Copy link
Collaborator

@tatomyr tatomyr commented Feb 26, 2025

What/Why/How?

  • Added a pre-commit hook (prettier + eslint) to improve the developer experience
  • Skip Rebilly smoke tests for external contributions (as they will fail anyway due to missing credentials)
  • Added Respect smokes
  • Added a pnpm smoke

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: 0ef84ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 953.1 ± 22.4 921.3 995.3 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 958.3 ± 22.5 933.5 996.4 1.01 ± 0.03

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.19% 6937/8760
🟡 Branches 68.29% 2875/4210
🟡 Functions 74.97% 1141/1522
🟡 Lines 79.56% 6612/8311

Test suite run success

1323 tests passing in 189 suites.

Report generated by 🧪jest coverage report action from 0ef84ea

@tatomyr tatomyr changed the title chore: add precommit hook chore: add precommit hook and improve smoke tests Feb 26, 2025
@tatomyr tatomyr changed the title chore: add precommit hook and improve smoke tests chore: add a precommit hook and improve smoke tests Feb 26, 2025
@tatomyr tatomyr force-pushed the chore/add-precommit branch from a290bff to 4a49786 Compare February 26, 2025 21:35
@tatomyr tatomyr force-pushed the chore/add-precommit branch from 4a49786 to 0ef84ea Compare February 26, 2025 21:41
@tatomyr tatomyr marked this pull request as ready for review February 26, 2025 21:47
@tatomyr tatomyr requested a review from a team as a code owner February 26, 2025 21:47
@Marshevskyy Marshevskyy merged commit 9f96ef3 into main Feb 27, 2025
41 checks passed
@Marshevskyy Marshevskyy deleted the chore/add-precommit branch February 27, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants