refactor: use stderr for all output except for the output for program…#2033
Merged
andriimredocly merged 1 commit intov2from Apr 1, 2025
Merged
refactor: use stderr for all output except for the output for program…#2033andriimredocly merged 1 commit intov2from
andriimredocly merged 1 commit intov2from
Conversation
|
tatomyr
reviewed
Mar 31, 2025
tatomyr
reviewed
Mar 31, 2025
tatomyr
approved these changes
Mar 31, 2025
andriimredocly
force-pushed
the
refactor/logger
branch
from
712febb to
a00aed8
Compare
tatomyr
approved these changes
Mar 31, 2025
tatomyr
reviewed
Mar 31, 2025
| }); | ||
|
|
||
| it('should throw an error if rules are not provided', () => { | ||
| vi.mocked(red).mockImplementation((text) => text as string); |
tatomyr
reviewed
Mar 31, 2025
| }); | ||
|
|
||
| expect(process.stderr.write).toBeCalledTimes(2); | ||
| expect(vi.mocked(process.stderr.write)).toBeCalledTimes(2); |
tatomyr
approved these changes
Mar 31, 2025
andriimredocly
added a commit
that referenced
this pull request
Apr 1, 2025
andriimredocly
added a commit
that referenced
this pull request
Apr 9, 2025
tatomyr
pushed a commit
that referenced
this pull request
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Refactor the CLI logger to use stderr for all text output except the output that the user may want to use programmatically - it is sent to stdout. Use in cli package the logger from openapi-core
Reference
Testing
Screenshots (optional)
Check yourself
Security