Skip to content

refactor: use same output method for commands#2036

Merged
andriimredocly merged 3 commits intov2from
refactor/use-same-output-method-for-commands
Apr 7, 2025
Merged

refactor: use same output method for commands#2036
andriimredocly merged 3 commits intov2from
refactor/use-same-output-method-for-commands

Conversation

@andriimredocly
Copy link
Contributor

@andriimredocly andriimredocly commented Apr 1, 2025 •
edited
Loading

What/Why/How?

The lint and stats outputs should be sent to the same output stream, disregarding the requested format

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: fba6ae6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

tatomyr
tatomyr approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@tatomyr tatomyr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an explanation somewhere in the CONTRIBUTING guide how do we use the logger and what's being logged to stdout/stderr/browser console &c. (and a couple of words regarding the snapshot testing approach).

Smokes are failing due to an external package version change (will be fixed after merging this: #2037).

@andriimredocly andriimredocly force-pushed the refactor/use-same-output-method-for-commands branch from 2ffa71e to fba6ae6 Compare April 7, 2025 08:09
@andriimredocly andriimredocly marked this pull request as ready for review April 7, 2025 08:09
@andriimredocly andriimredocly requested a review from a team as a code owner April 7, 2025 08:09
@andriimredocly andriimredocly merged commit 22d50a9 into v2 Apr 7, 2025
23 of 29 checks passed
@andriimredocly andriimredocly deleted the refactor/use-same-output-method-for-commands branch April 7, 2025 09:09
andriimredocly added a commit that referenced this pull request Apr 9, 2025
@andriimredocly
refactor: use same output method for commands (#2036)
d32905a 
* refactor/print-lint-output-to-stdout

* Update snaphosts

* refactor: use the same output for stats command
tatomyr pushed a commit that referenced this pull request Apr 16, 2025
@andriimredocly @tatomyr
refactor: use same output method for commands (#2036)
0a66d8d 
* refactor/print-lint-output-to-stdout

* Update snaphosts

* refactor: use the same output for stats command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tatomyr tatomyr tatomyr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andriimredocly @tatomyr