Skip to content

refactor: unified error logging #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andriimredocly merged 1 commit into from
Apr 8, 2025
Merged

refactor: unified error logging #2045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __tests__/respect/local-json-server/__snapshots__/local-json-server.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ exports[`local-json-server > local-json-server test case 1`] = `
└───────────────────────────────────────────────────────────────────────┴────────────┴─────────┴─────────┴──────────┘



Tests exited with error

"
`;
2 changes: 1 addition & 1 deletion __tests__/respect/max-steps/__snapshots__/max-steps.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ exports[`should quit an infinite loop on RESPECT_MAX_STEPS 1`] = `
└─────────────────────────────────────────────────────┴────────────┴─────────┴─────────┴──────────┘



Tests exited with error

"
`;
2 changes: 1 addition & 1 deletion __tests__/respect/reusable-components/__snapshots__/reusable-components.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ exports[`should use inputs from CLI and env to map with resolved refs 1`] = `
└─────────────────────────────────────────────────────────────────────────┴────────────┴─────────┴─────────┴──────────┘



Tests exited with error

"
`;
2 changes: 1 addition & 1 deletion ...ith-console-parameters/__snapshots__/server-override-with-console-parameters.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ exports[`should use server override from CLI and env 1`] = `
└─────────────────────────────────────────────────────────────────────────────────────────────┴────────────┴─────────┴─────────┴──────────┘



Tests exited with error

"
`;
2 changes: 1 addition & 1 deletion __tests__/respect/severity-error-level/__snapshots__/severity-error-level.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ exports[`should use error severity level 1`] = `
└────────────────────────────────────────────────────────────────────┴────────────┴─────────┴─────────┴──────────┘



Tests exited with error

"
`;
2 changes: 1 addition & 1 deletion ...tep-on-failure-type-end-action/__snapshots__/step-on-failure-type-end-action.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ exports[`should end workflow execution, context returns to the caller with appli
└─────────────────────────────────────────────────────────────────────────────────────┴────────────┴─────────┴─────────┴──────────┘



Tests exited with error

"
`;
2 changes: 1 addition & 1 deletion ...ts__/respect/workflow-failure-actions/__snapshots__/workflow-failure-actions.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ exports[`should execute successActions for each workflow step if it does not hav
└──────────────────────────────────────────────────────────────────────────────┴────────────┴─────────┴─────────┴──────────┘



Tests exited with error

"
`;
11 changes: 1 addition & 10 deletions packages/cli/src/wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,7 @@ export function commandWrapper<T extends CommandOptions>(
if (err instanceof AbortFlowError) {
// do nothing
} else if (err instanceof HandledError) {
// FIXME: remove differentiator between respect and openapi-core error logging
if (
process.env.REDOCLY_CLI_COMMAND === 'respect' ||
process.env.REDOCLY_CLI_COMMAND === 'generate-arazzo'
) {
logger.error(err.message + '\n');
logger.output('\n');
} else {
logger.error(err.message + '\n\n');
}
logger.error(err.message + '\n\n');
} else {
logger.error(
'An unexpected error occurred. This is likely a bug that should be reported.\n'
Expand Down
Loading