fix: fixed the wrong validation of constructor property#2126
Merged
RomanHotsiy merged 5 commits intomainfrom Jun 4, 2025
Merged
fix: fixed the wrong validation of constructor property#2126RomanHotsiy merged 5 commits intomainfrom
RomanHotsiy merged 5 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 7ea4382 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
RomanHotsiy
changed the title
tatomyr
reviewed
Jun 4, 2025
RomanHotsiy
force-pushed
the
fix-constructor-property-validation
branch
from
cc1da8d to
c046628
Compare
tatomyr
reviewed
Jun 4, 2025
JLekawa
reviewed
Jun 4, 2025
JLekawa
approved these changes
Jun 4, 2025
tatomyr
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Because we used regular objects we mistakenly were getting
constructorproperty validated incorrectly.Reference
Fixes #2104
Testing
Added e2e.
Check yourself
Security