Skip to content

chore: fix pre-commit hook and improve the test script#2129

Merged
tatomyr merged 1 commit intomainfrom
chore/improve-scripts
Jun 10, 2025
Merged

chore: fix pre-commit hook and improve the test script#2129
tatomyr merged 1 commit intomainfrom
chore/improve-scripts

Conversation

@tatomyr
Copy link
Collaborator

@tatomyr tatomyr commented Jun 10, 2025

What/Why/How?

  • Fixed the pre-commit hook (now it gets created after npm i)
  • Moved the compile script before typecheck as we need openapi-core to be compiled before checking the types in cli.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2025

⚠️ No Changeset found

Latest commit: 1a1d659

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tatomyr tatomyr marked this pull request as ready for review June 10, 2025 16:28
@tatomyr tatomyr requested a review from a team as a code owner June 10, 2025 16:28
@github-actions
Copy link
Contributor

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 944.3 ± 22.3 922.3 996.3 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1011.0 ± 20.6 976.4 1035.9 1.07 ± 0.03

@tatomyr tatomyr merged commit a3af538 into main Jun 10, 2025
38 checks passed
@tatomyr tatomyr deleted the chore/improve-scripts branch June 10, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants