feat: added new `duplicate tag names` rule#2157

Merged

tatomyr merged 31 commits intoRedocly:mainfrom

AlbinaBlazhko17:feat/duplicate-tag-names-rule

Jul 9, 2025

Contributor

AlbinaBlazhko17 commented Jul 1, 2025 •

edited by tatomyr

Loading

What/Why/How?

Added new duplicate tag names common rule due to opened Issue #1732

Reference

Closes #1732

Testing

Screenshots (optional)

Check yourself

Code changed? - Tested with redoc (internal)
All new/updated code is covered with tests
New package installed? - Tested in different environments (browser/node)

Security

Security impact of change has been considered
Code follows company security practices and guidelines

AlbinaBlazhko17 requested review from a team as code owners

July 1, 2025 12:35

changeset-bot bot commented Jul 1, 2025 •

edited

Loading

🦋 Changeset detected

Latest commit: 21bf108

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@redocly/openapi-core	Minor
@redocly/cli	Minor
@redocly/respect-core	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tatomyr reviewed

View reviewed changes

packages/core/src/rules/oas3/__tests__/struct/struct.test.ts Outdated Show resolved Hide resolved

petstore.json Outdated Show resolved Hide resolved

docs/@v2/rules/oas/tags-duplicated-names.md Outdated Show resolved Hide resolved

docs/@v2/rules/oas/tags-duplicated-names.md Outdated Show resolved Hide resolved

tatomyr reviewed

View reviewed changes

__tests__/lint/tags-duplicated-names/snapshot.txt Outdated Show resolved Hide resolved

DmitryAnansky reviewed

View reviewed changes

__tests__/lint/tags-duplicated-names/snapshot.txt Outdated Show resolved Hide resolved

tatomyr reviewed

View reviewed changes

.changeset/orange-ghosts-hug.md Outdated Show resolved Hide resolved

JLekawa reviewed

View reviewed changes

.changeset/orange-ghosts-hug.md Outdated Show resolved Hide resolved

JLekawa reviewed

View reviewed changes

docs/@v2/rules/async/tags-duplicated-names.md Outdated Show resolved Hide resolved

docs/@v2/rules/async/tags-duplicated-names.md Outdated Show resolved Hide resolved

docs/@v2/rules/oas/tags-duplicated-names.md Outdated Show resolved Hide resolved

docs/@v2/rules/oas/tags-duplicated-names.md Outdated Show resolved Hide resolved

JLekawa reviewed

View reviewed changes

.changeset/orange-ghosts-hug.md Outdated Show resolved Hide resolved

tatomyr reviewed

View reviewed changes

.changeset/orange-ghosts-hug.md Outdated Show resolved Hide resolved

tatomyr reviewed

View reviewed changes

packages/core/src/rules/common/tags-duplicated-names.ts Outdated Show resolved Hide resolved

tatomyr reviewed

View reviewed changes

packages/core/src/rules/common/tags-duplicated-names.ts Outdated Show resolved Hide resolved

tatomyr reviewed

View reviewed changes

.changeset/orange-ghosts-hug.md Outdated Show resolved Hide resolved

tatomyr reviewed

View reviewed changes

packages/core/src/rules/common/no-duplicated-tag-names.ts Outdated Show resolved Hide resolved

Collaborator

tatomyr commented Jul 7, 2025

Thank you for your contribution @AlbinaBlazhko17! Left a minor suggestion, but otherwise looks good to me. Let's wait for approval from the tech writers, and we'll be good to go.

Contributor Author

AlbinaBlazhko17 commented Jul 7, 2025

Thank you for your contribution @AlbinaBlazhko17! Left a minor suggestion, but otherwise looks good to me. Let's wait for approval from the tech writers, and we'll be good to go.

Thank you @tatomyr for your help in developing this feature! I learned a lot of new things. I look forward to further cooperation together

JLekawa reviewed

View reviewed changes

docs/@v2/rules/oas/no-duplicated-tag-names.md Outdated Show resolved Hide resolved

docs/@v2/rules/async/no-duplicated-tag-names.md Outdated Show resolved Hide resolved

JLekawa approved these changes

View reviewed changes

AlbinaBlazhko17 added 11 commits

July 9, 2025 11:47


          feat: add tags duplicated names

1e86a98


          chore: remove getTagName function and import it from utils

93835ab


          feat: improve for loop

28a7ffc


          feat: add tests

5c9106e


          feat: add rule to the configs

8fce0ad


          fix: spelling inside all config

5d74e8c


          fix: global tests and regenerate snapshot

902f7e2


          chore: add docs

3408cca


          feat: add changelog

34c09eb


          chore: remove testing file

6516b26


          fix: change inside docs default behavior from error to warn

11ced3f

AlbinaBlazhko17 and others added 20 commits

July 9, 2025 11:47


          fix: change inside snapshot error to warning

cdf1278


          feat: add async types

54ee6af


          feat: add docs for the async api

4bea4f3


          chore: remove related rules error

04b1f75


          chore: change changeset sentence

098c090


          feat: change function structure to validate schema

b94ddea


          fix: e2e test

cb5bc3a


          Apply suggestions from code review

ea51c42


          chore: rename rule from tags-duplicated-names to no-duplicated-tag-names

a59bc10


          chore: change changelog version from major to minor

9e5de60


          feat: add inside changelog @redocly/cli version

c54bba0


          chore: change naming of the test

1c36cb3


          fix: tests for the new rule

0bd01b4


          fix: remove root tags check and add proper location without child

590c07d


          chore: rename e2e test folder for new rule and update snapshot

a9c336b


          chore: remove minus symbol in changeset

42a43be


          Apply suggestions from code review

8b11a24


          chore: add dot in the end of the report message

8e6aa00


          chore: update snapshots

ad9ee38


          chore: update snapshot

21bf108

tatomyr force-pushed the feat/duplicate-tag-names-rule branch from bbdfb08 to 21bf108 Compare

July 9, 2025 08:47

tatomyr approved these changes

View reviewed changes

tatomyr merged commit 8114203 into Redocly:main

32 checks passed

Collaborator

tatomyr commented Jul 9, 2025

@AlbinaBlazhko17 thank you for your contribution! Your changes will become available with the next release.

Contributor Author

AlbinaBlazhko17 commented Jul 9, 2025

@AlbinaBlazhko17 thank you for your contribution! Your changes will become available with the next release.

@tatomyr Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet